-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/ssa: TestStdlib failures #60263
Comments
Found new dashboard test flakes for:
2023-05-16 19:01 linux-386-longtest tools@522243a7 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 19:01 linux-amd64-longtest tools@522243a7 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 19:01 linux-amd64-longtest-race tools@522243a7 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 19:01 linux-arm64-longtest tools@522243a7 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 19:01 windows-amd64-longtest tools@522243a7 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
|
Appears to have been fixed by https://go.dev/cl/495475 (CC @cherrymui @prattmic). |
Found new dashboard test flakes for:
2023-05-16 20:18 darwin-amd64-longtest tools@743372f5 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 20:18 linux-386-longtest tools@743372f5 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 20:18 linux-amd64-longtest tools@743372f5 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 20:18 linux-amd64-longtest-race tools@743372f5 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 20:18 linux-arm64-longtest tools@743372f5 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
2023-05-16 20:18 windows-amd64-longtest tools@743372f5 go@ad6dcf9d x/tools/go/ssa.TestStdlib (log)
|
We decided that this is an unrobust test. @adonovan you mentioned you were looking into fixing the test. Is that still the case or should I take a look? |
Change https://go.dev/cl/496575 mentions this issue: |
Change https://go.dev/cl/497455 mentions this issue: |
Reapples CL 495596, which was reverted at CL 496185. The x/tools failure, #60263, has been resolved. The ppc64 failures, #60368, have _not_ been resolved, but are believed to be specific to that port. This CL will make ppc64 flaky while the issue is investigated, but give more soak time on primary ports. Build the compiler with PGO. As go build -pgo=auto is enabled by default, we just need to store a profile in the compiler's directory. The profile is collected from building all std and cmd packages on Linux/AMD64 machine, using profile.sh. This improves the compiler speed. On Linux/AMD64, name old time/op new time/op delta Template 138ms ± 5% 136ms ± 4% -1.44% (p=0.005 n=36+39) Unicode 147ms ± 4% 140ms ± 4% -4.99% (p=0.000 n=40+39) GoTypes 780ms ± 3% 778ms ± 4% ~ (p=0.172 n=39+39) Compiler 105ms ± 5% 99ms ± 7% -5.64% (p=0.000 n=40+40) SSA 5.83s ± 6% 5.80s ± 6% ~ (p=0.556 n=40+40) Flate 89.0ms ± 5% 87.0ms ± 6% -2.18% (p=0.000 n=40+40) GoParser 172ms ± 4% 167ms ± 4% -2.72% (p=0.000 n=39+40) Reflect 333ms ± 4% 333ms ± 3% ~ (p=0.426 n=40+39) Tar 128ms ± 4% 126ms ± 4% -1.82% (p=0.000 n=39+39) XML 173ms ± 4% 170ms ± 4% -1.39% (p=0.000 n=39+40) [Geo mean] 253ms 248ms -2.13% The profile is pretty transferable. Using the same profile, we see a bigger win on Darwin/ARM64, name old time/op new time/op delta Template 71.0ms ± 2% 68.3ms ± 2% -3.90% (p=0.000 n=20+20) Unicode 71.8ms ± 2% 66.8ms ± 2% -6.90% (p=0.000 n=20+20) GoTypes 444ms ± 1% 428ms ± 1% -3.53% (p=0.000 n=19+20) Compiler 48.9ms ± 3% 45.6ms ± 3% -6.81% (p=0.000 n=20+20) SSA 3.25s ± 2% 3.09s ± 1% -5.03% (p=0.000 n=19+20) Flate 44.0ms ± 2% 42.3ms ± 2% -3.72% (p=0.000 n=19+20) GoParser 76.7ms ± 1% 73.5ms ± 1% -4.15% (p=0.000 n=18+19) Reflect 172ms ± 1% 165ms ± 1% -4.13% (p=0.000 n=20+19) Tar 63.1ms ± 1% 60.4ms ± 2% -4.24% (p=0.000 n=19+20) XML 83.2ms ± 2% 79.2ms ± 2% -4.79% (p=0.000 n=20+20) [Geo mean] 127ms 121ms -4.73% For #60368. Change-Id: I2cec0fc85e21c38d57ba6f0e5e90cde5d443ebd2 Reviewed-on: https://go-review.googlesource.com/c/go/+/497455 Reviewed-by: Austin Clements <austin@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
Found new dashboard test flakes for:
2024-02-16 15:54 x_tools-gotip-darwin-amd64-longtest tools@0d171942 go@86a32d6d x/tools/go/ssa.TestStdlib [ABORT] (log)
|
The 16 Feb flake is another case of a hanging go command, #54461. |
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: