Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: test that BoringCrypto is actually used #60252

Open
FiloSottile opened this issue May 17, 2023 · 0 comments
Open

crypto: test that BoringCrypto is actually used #60252

FiloSottile opened this issue May 17, 2023 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@FiloSottile
Copy link
Contributor

#58803 is about BoringCrypto not being used for generating 4096-bit keys. In general, we don't have tests that check that BoringCrypto is actually used (when enabled) instead of Go crypto for operations that are in scope.

This is somewhat tricky to test. @rolandshoemaker suggested using the BoringCrypto counters.
@FiloSottile FiloSottile added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 17, 2023
@FiloSottile FiloSottile added this to the Backlog milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@FiloSottile