Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/crypto: Not all parameters of the argon 2 specification are included in spec #60179

Closed
peter021 opened this issue May 13, 2023 · 1 comment
Labels
Milestone

Comments

@peter021
Copy link

The current interfaces are:
func IDKey(password, salt []byte, time, memory uint32, threads uint8, keyLen uint32) []byte
func Key(password, salt []byte, time, memory uint32, threads uint8, keyLen uint32) []byte

Parameters "Secret" and "Associated data" mentioned in the spec https://github.com/P-H-C/phc-winner-argon2/blob/master/argon2-specs.pdf are not listed in the above definition.

Parameter secret is meant for creating application specific hashes.

Parameter "Associated data" is meant for a hash calculated on session specific data. A password and salt should for some use cases return different hashes based on agreed session specific data: A date value (new keys each day?); user data; direction data; protocol data; classifications data; filenames, and whatever both ends of the session agree on.

How do we get those important parameters included?

@gopherbot gopherbot added this to the Proposal milestone May 13, 2023
@seankhliao
Copy link
Member

Duplicate of #35481

@seankhliao seankhliao marked this as a duplicate of #35481 May 13, 2023
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants