Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: graph pruning not applied during 'go get' [1.19 backport] #60159

Closed
gopherbot opened this issue May 12, 2023 · 3 comments
Closed

cmd/go: graph pruning not applied during 'go get' [1.19 backport] #60159

gopherbot opened this issue May 12, 2023 · 3 comments
Labels
CherryPickCandidate Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.19.13

Comments

@gopherbot
Copy link

@bcmills requested issue #55955 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19 and 1.20. This bug causes go get to fail in very confusing ways; the fix is very invasive but mostly only affects 'go get'. (It isn't clear to me whether we should approve these backports, but I'm filing them for discussion.)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 12, 2023
@gopherbot gopherbot mentioned this issue May 12, 2023
Closed
@gopherbot gopherbot added this to the Go1.19.10 milestone May 12, 2023
@heschi heschi added the GoCommand cmd/go label May 17, 2023
@gopherbot gopherbot modified the milestones: Go1.19.10, Go1.19.11 Jun 6, 2023
@joedian
Copy link

joedian commented Jul 5, 2023

@bcmills can we have the Cl this?

@bcmills
Copy link
Contributor

bcmills commented Jul 5, 2023

I haven't prepared a backport CL yet because I'm not entirely convinced we should actually backport it. 😅

@gopherbot gopherbot modified the milestones: Go1.19.11, Go1.19.12 Jul 11, 2023
@gopherbot gopherbot modified the milestones: Go1.19.12, Go1.19.13 Aug 1, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 15, 2023 •
edited

At this point I don't think this is worth the risk to backport: running go get using Go 1.21.0 should work, and should produce a go.mod file that Go 1.19.* can work with unchanged.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.19.13
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @joedian @heschi