Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestNonPollable failures #60133

Closed
gopherbot opened this issue May 11, 2023 · 5 comments
Closed

os: TestNonPollable failures #60133

gopherbot opened this issue May 11, 2023 · 5 comments
Assignees
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "os" && test == "TestNonPollable"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestNonPollable (0.42s)
    fifo_test.go:148: read from fifo 3109 failed; read /workdir/tmp/TestNonPollable432607022/001/3109: not pollable

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 11, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "os" && test == "TestNonPollable"
2023-05-11 21:27 linux-386-longtest go@8992bb19 os.TestNonPollable (log)
--- FAIL: TestNonPollable (0.42s)
    fifo_test.go:148: read from fifo 3109 failed; read /workdir/tmp/TestNonPollable432607022/001/3109: not pollable

watchflakes

@bcmills
Copy link
Contributor

bcmills commented May 12, 2023

(attn @ianlancetaylor)

@bcmills bcmills added this to the Go1.21 milestone May 12, 2023
@bcmills
Copy link
Contributor

bcmills commented May 12, 2023

This is the regression test for #59545, added in https://go.dev/cl/484837.

Marking as release-blocker for Go 1.21 because the test is new in Go 1.21 (and linux/386 is a first-class port).

@ianlancetaylor
Copy link
Contributor

I was unable to reproduce this running the test over 10,000 times. Still, I may have found a small hole. Will send a CL.

@gopherbot
Copy link
Author

Change https://go.dev/cl/495297 mentions this issue: runtime: publish netpoll info after incrementing fdseq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Status: Done
Development

No branches or pull requests

3 participants