Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestPlatformVerifier fails on windows-amd64-longtest-oldcc builder on 1.19 release branch #60118

Closed
cherrymui opened this issue May 10, 2023 · 5 comments
Closed

crypto/x509: TestPlatformVerifier fails on windows-amd64-longtest-oldcc builder on 1.19 release branch #60118

cherrymui opened this issue May 10, 2023 · 5 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Security Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19.13

Comments

@cherrymui
Copy link
Member

It fails on the dashboard for 1.19 release branch
https://build.golang.org/log/e91a530bfdb6f096ad81e08a8fbaf88aa62d957b
https://build.golang.org/log/3d0f6bb48b4df90269fac5cf522a37332c150955
Interestingly it did not fail at the latest commit 484330d on the branch.

Failed also pretty consistently in trybot runs at CL https://golang.org/cl/492697
https://storage.googleapis.com/go-build-log/ea1147d1/windows-amd64-longtest-oldcc_a8321ffb.log

Might be related to #58810 ?
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 10, 2023
@cherrymui cherrymui added this to the Go1.19.10 milestone May 10, 2023
@cherrymui
Copy link
Member Author

cc @dmitshur @golang/release

@bcmills
Copy link
Contributor

bcmills commented May 11, 2023

(CC @rolandshoemaker; see also #52108.)

@dmitshur
Copy link
Contributor

dmitshur commented Jun 6, 2023

CC @dr2chase, @mknyszek.

@gopherbot gopherbot modified the milestones: Go1.19.10, Go1.19.11 Jun 6, 2023
@bcmills bcmills added Security Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 9, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 9, 2023
@cagedmantis
Copy link
Contributor

Are there any plans to fix this before the next release? Should we just skip the test?

@gopherbot gopherbot modified the milestones: Go1.19.11, Go1.19.12 Jul 11, 2023
@gopherbot gopherbot modified the milestones: Go1.19.12, Go1.19.13 Aug 1, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Aug 16, 2023 •
edited

This test is being fixed at tip in #52108, but the changes required to fix it are very large and not a great fit for backporting. So skipping the test on this old release branch is fine. But since we got through many minor releases by working around this flaky test, I expect we can get through one more. If that isn't the case, I'll reopen.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. Security Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19.13
Development

No branches or pull requests
5 participants
@cagedmantis @dmitshur @bcmills @gopherbot @cherrymui