Skip to content

x/vulndb: remove dependency on outdated version of x/vuln #60116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julieqiu opened this issue May 10, 2023 · 1 comment
Closed

x/vulndb: remove dependency on outdated version of x/vuln #60116

julieqiu opened this issue May 10, 2023 · 1 comment
Assignees
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone

Comments

@julieqiu
Copy link
Member

An old version x/vuln is currently used by x/vulndb due to dependencies in:

https://github.com/golang/vulndb/blob/7c92a880ccd96e949cfe229ffb0914f84bd5c4f7/cmd/vulnreport/exported_functions.go#L16
https://github.com/golang/vulndb/blob/7c92a880ccd96e949cfe229ffb0914f84bd5c4f7/internal/worker/worker.go#L26

We are currently refactoring x/vuln/internal/vulncheck. Once that is done, we should copy the relevant code and remove this dependency.

@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label May 10, 2023
@julieqiu julieqiu added this to the vuln/v0.2.0 milestone May 10, 2023
@tatianab tatianab self-assigned this May 22, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/497039 mentions this issue: internal/worker: use function Aliases instead of x/vuln client

@golang golang locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Development

No branches or pull requests

4 participants