Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modfetch: TestCodeRepoVersions failures #60113

Open
gopherbot opened this issue May 10, 2023 · 3 comments
Open

cmd/go/internal/modfetch: TestCodeRepoVersions failures #60113

gopherbot opened this issue May 10, 2023 · 3 comments
Labels
GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@gopherbot
Copy link

gopherbot commented May 10, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "cmd/go/internal/modfetch" && `test timed out` && `^cmd/go/internal/web\.Get`

Issue created automatically to collect these failures.

Example (log):

vcs-test.golang.org rerouted to http://127.0.0.1:40375
https://vcs-test.golang.org rerouted to https://127.0.0.1:38347
panic: test timed out after 15m0s
running tests:
	TestCodeRepoVersions (14m27s)
	TestCodeRepoVersions/parallel (14m27s)
	TestCodeRepoVersions/parallel/swtch.com_testmod (14m27s)

runtime.gopark(0xc000079e00?, 0x40dec5?, 0x50?, 0x36?, 0x18?)
	/workdir/go/src/runtime/proc.go:387 +0xce fp=0xc000079d98 sp=0xc000079d78 pc=0x43ae4e
runtime.chanrecv(0xc00030a3f0, 0xc000079e7f, 0x1)
	/workdir/go/src/runtime/chan.go:583 +0x3cd fp=0xc000079e10 sp=0xc000079d98 pc=0x40752d
runtime.chanrecv1(0xb43700?, 0x7b0de0?)
	/workdir/go/src/runtime/chan.go:442 +0x12 fp=0xc000079e38 sp=0xc000079e10 pc=0x407152
testing.(*T).Run(0xc0002bd1e0, {0x839a87?, 0x83ea2f?}, 0x876e48)
	/workdir/go/src/testing/testing.go:1649 +0x3c8 fp=0xc000079ef8 sp=0xc000079e38 pc=0x501548
cmd/go/internal/modfetch.TestCodeRepoVersions(0xc0002bd1e0)
	/workdir/go/src/cmd/go/internal/modfetch/coderepo_test.go:825 +0xe5 fp=0xc000079f70 sp=0xc000079ef8 pc=0x7812e5
testing.tRunner(0xc0002bd1e0, 0x876c98)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 10, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/modfetch" && test == "TestCodeRepoVersions"
2023-05-10 14:36 linux-amd64-longtest go@46847c63 cmd/go/internal/modfetch.TestCodeRepoVersions (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:40375
https://vcs-test.golang.org rerouted to https://127.0.0.1:38347
panic: test timed out after 15m0s
running tests:
	TestCodeRepoVersions (14m27s)
	TestCodeRepoVersions/parallel (14m27s)
	TestCodeRepoVersions/parallel/swtch.com_testmod (14m27s)

runtime.gopark(0xc000079e00?, 0x40dec5?, 0x50?, 0x36?, 0x18?)
	/workdir/go/src/runtime/proc.go:387 +0xce fp=0xc000079d98 sp=0xc000079d78 pc=0x43ae4e
runtime.chanrecv(0xc00030a3f0, 0xc000079e7f, 0x1)
	/workdir/go/src/runtime/chan.go:583 +0x3cd fp=0xc000079e10 sp=0xc000079d98 pc=0x40752d
runtime.chanrecv1(0xb43700?, 0x7b0de0?)
	/workdir/go/src/runtime/chan.go:442 +0x12 fp=0xc000079e38 sp=0xc000079e10 pc=0x407152
testing.(*T).Run(0xc0002bd1e0, {0x839a87?, 0x83ea2f?}, 0x876e48)
	/workdir/go/src/testing/testing.go:1649 +0x3c8 fp=0xc000079ef8 sp=0xc000079e38 pc=0x501548
cmd/go/internal/modfetch.TestCodeRepoVersions(0xc0002bd1e0)
	/workdir/go/src/cmd/go/internal/modfetch/coderepo_test.go:825 +0xe5 fp=0xc000079f70 sp=0xc000079ef8 pc=0x7812e5
testing.tRunner(0xc0002bd1e0, 0x876c98)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented May 10, 2023

Looks like it was waiting ~14m for a response from swtch.com, which makes this probably another symptom of #49954.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels May 10, 2023
@bcmills bcmills added this to the Backlog milestone May 10, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/494375 mentions this issue: cmd/go/internal/modfetch: avoid creating unused temp directories

gopherbot pushed a commit that referenced this issue May 18, 2023
@gopherbot
cmd/go/internal/modfetch: avoid creating unused temp directories
c7d6c60 
(Discovered via #60113, but this doesn't address that issue.)

Change-Id: I8b89e74b786dcfb0aa5d71fcbd0df8af33b98f36
Reviewed-on: https://go-review.googlesource.com/c/go/+/494375
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot