-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/pprof: test timed out in StartCPUProfile
#60108
Comments
Found new dashboard test flakes for:
2023-05-03 18:47 darwin-amd64-race go@ea9097c9 runtime/pprof (log)
|
StartCPUProfile
StartCPUProfile
on darwin-amd64-race
Related to #59995? |
Found new dashboard test flakes for:
2023-05-19 18:01 darwin-amd64-race go@b60db8f7 runtime/pprof (log)
|
Found new dashboard test flakes for:
2023-05-24 14:43 darwin-amd64-race go@d9fd19a7 runtime/pprof (log)
|
Found new dashboard test flakes for:
2023-06-03 00:53 darwin-amd64-race go@3fd867ce runtime/pprof (log)
|
Found new dashboard test flakes for:
2023-05-04 17:28 darwin-amd64-race go@60c724c5 runtime/pprof.TestCPUProfileWithFork (log)
2023-05-10 14:30 darwin-amd64-race go@8e8303e1 runtime/pprof.TestCPUProfileWithFork (log)
2023-05-10 21:44 darwin-amd64-race go@3f9521b2 runtime/pprof.TestCPUProfileWithFork (log)
|
Found new dashboard test flakes for:
2023-06-14 21:53 darwin-amd64-race go@b01cd41b runtime/pprof (log)
|
I wonder if this is related to #18717. Do we know if |
The answer as of https://go.dev/cl/451055 seems to be no. So, that's my theory: the TSAN runtime is deferring signals as described in #18717, but the workaround added to the |
One possible fix, in the spirit of https://go.dev/cl/451055, would be to have |
Change https://go.dev/cl/507356 mentions this issue: |
But I wonder: since we're linking against |
I think we use the bundled TSAN implementation from the race syso files. I don't think the libc we use contains TSAN. |
Found new dashboard test flakes for:
2023-05-23 17:16 darwin-amd64-race go@4e679e26 runtime/pprof.TestCPUProfileWithFork (log)
2023-06-21 19:47 darwin-amd64-race go@b23cae80 runtime/pprof.TestCPUProfileWithFork (log)
2023-06-29 22:49 darwin-amd64-race go@683f51d3 runtime/pprof (log)
|
If the test is about to time out, testenv.Command sends SIGQUIT to the child process. The runtime's SIGQUIT goroutine dump should help us to determine whether the hangs observed in TestCPUProfileWithFork are a symptom of #60108 or a separate bug. For #59995. Updates #60108. Change-Id: I26342ca262b2b0772795c8be142cfcad8d90db30 Reviewed-on: https://go-review.googlesource.com/c/go/+/507356 Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Bryan Mills <bcmills@google.com>
Found new dashboard test flakes for:
2023-08-01 17:16 darwin-amd64-race go@b6898dde runtime/pprof.TestCPUProfileWithFork (log)
|
Found new dashboard test flakes for:
2023-07-19 21:06 darwin-amd64-race go@03c7e96b runtime/pprof.TestCPUProfileWithFork (log)
2023-07-21 03:06 darwin-amd64-race go@2fabb143 runtime/pprof (log)
|
Found new dashboard test flakes for:
2023-08-12 03:56 linux-arm-aws go@ac64a362 runtime/pprof.TestGoroutineSwitch (log)
|
As of the resolution of #61768, I think this is also fixed. gopherbot will reopen it if not true, but we haven't seen any issues in a couple weeks. |
Found new dashboard test flakes for:
2024-04-03 15:35 go1.21-linux-arm release-branch.go1.21@d8392e69 runtime/pprof.TestEmptyCallStack [ABORT] (log)
2024-04-03 15:35 go1.21-linux-arm release-branch.go1.21@d8392e69 runtime/pprof.TestLabelSystemstack [ABORT] (log)
|
StartCPUProfile
on darwin-amd64-raceStartCPUProfile
Closing in favor of #67023. |
https://build.golang.org/log/e7671b5aac25301376187c735141b1a0dd33bbe0 (from #57995 (comment)):
The text was updated successfully, but these errors were encountered: