Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: wasip1 is broken on wasmedge runtime #60097

Open
johanbrandhorst opened this issue May 10, 2023 · 9 comments
Open

build: wasip1 is broken on wasmedge runtime #60097

johanbrandhorst opened this issue May 10, 2023 · 9 comments
Labels
arch-wasm WebAssembly issues NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@johanbrandhorst
Copy link
Member

johanbrandhorst commented May 10, 2023 •
edited

This is a tracking issue for issues surrounding the use of the new wasip1 GOOS target on the wasmedge Wasm runtime. We currently do not have a wasmedge runner.

This issue should not be considered done until we have a working wasmedge runner and all tests are either passing or we have documented the failures which we cannot reasonably fix.

Currently known failing tests:

Package Test name Error Test log Fixed
archive/zip TestOpenReaderInsecurePath Unable to write out the bugos zip entry Full log ✔️
all N/A Test timeout Full log
@johanbrandhorst johanbrandhorst added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-wasm WebAssembly issues labels May 10, 2023
@johanbrandhorst johanbrandhorst added this to the Backlog milestone May 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/493696 mentions this issue: all: add wasmedge wasip1 runner

@gopherbot
Copy link

Change https://go.dev/cl/494120 mentions this issue: misc/wasm: add wasmedge to wasip1 script

gopherbot pushed a commit to golang/build that referenced this issue May 10, 2023
@johanbrandhorst @gopherbot
all: add wasmedge wasip1 runner
fc985e8 
The wasmedge runner provides the wasmedge.org WASI runtime
for testing the wasip1 implementation.

For golang/go#60097

Change-Id: I1148977296d00163f638d4fcc7a916c58c6d17c5
Reviewed-on: https://go-review.googlesource.com/c/build/+/493696
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue May 11, 2023
@johanbrandhorst @gopherbot
misc/wasm: add wasmedge to wasip1 script
dc076ea 
The wasmedge runtime will be used to test our wasip1
implementation against the WASI runtime from wasmedge.org.

For #60097

Change-Id: Ib0e886de46240b4d43d02ec8a7bc7cea0730c162
Reviewed-on: https://go-review.googlesource.com/c/go/+/494120
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
@johanbrandhorst
Copy link
Member Author

The runner has been created and once the builders have been redeployed I will run it to see where it fails.

@gopherbot
Copy link

Change https://go.dev/cl/495078 mentions this issue: misc/wasm: test commit

@gopherbot
Copy link

Change https://go.dev/cl/496076 mentions this issue: env: add runtime library to wasmedge runner

gopherbot pushed a commit to golang/build that referenced this issue May 18, 2023
@johanbrandhorst @gopherbot
env: add runtime library to wasmedge runner
97f144a 
The runtime libraries were missed when the image was
originally created, resulting in a binary that failed at
runtime due to a missing library.

For golang/go#60097

Change-Id: I6ae15af905e0dc673bbc300b95662ccd3b65034e
Reviewed-on: https://go-review.googlesource.com/c/build/+/496076
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
@johanbrandhorst
Copy link
Member Author

OK after some fixes I managed to run the test suite against wasmedge and the first failure we're seeing is:

--- FAIL: TestOpenReaderInsecurePath (0.01s)
    reader_test.go:1386: Unable to write out the bugos zip entry
FAIL
FAIL	archive/zip	8.807s

I've updated the table at the top. This is a new type of error so more investigation will be necessary.

@gopherbot
Copy link

Change https://go.dev/cl/498616 mentions this issue: misc/wasm: set PATH variable in exec

gopherbot pushed a commit that referenced this issue May 26, 2023
@johanbrandhorst
misc/wasm: set PATH variable in exec
188066c 
The PATH variable is required to run the testenv tests.
Set it for all the runtime invocations where we don't
already set it by inheriting from the environment.

For #59583
For #59907
For #60097

Change-Id: If582dd8f086e3f40bc58d555f6034dcffe6f8e5f
Reviewed-on: https://go-review.googlesource.com/c/go/+/498616
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
@johanbrandhorst
Copy link
Member Author

Seems this test failure fixed itself, but now we have a new failure:

##### Testing packages.
*** Test killed with quit: ran too long (4m0s).
signal: quit (core dumped)
FAIL	archive/tar	240.085s
*** Test killed with quit: ran too long (4m0s).
signal: quit (core dumped)
FAIL	archive/zip	240.090s
*** Test killed with quit: ran too long (4m0s).
signal: quit (core dumped)
FAIL	bufio	240.058s
FAIL
go tool dist: Failed: exit status 1

Looks like execution is a bit too slow at this time. I will experiment with increasing the timeout to see if run into any other errors.

@johanbrandhorst
Copy link
Member Author

Even with a bumped timeout we see the same error: https://storage.googleapis.com/go-build-log/767af70d/wasip1-wasm-wasmedge_4134807c.log. We have an outstanding issue on the WasmEdge project that may need to be resolved before we can move forward with this: WasmEdge/WasmEdge#2445.

@johanbrandhorst johanbrandhorst mentioned this issue Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@johanbrandhorst @gopherbot