Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: exclude "golang.org/toolchain/*" from import completion suggestions #60062

Closed
hyangah opened this issue May 9, 2023 · 2 comments
Closed

x/tools/gopls: exclude "golang.org/toolchain/*" from import completion suggestions #60062

hyangah opened this issue May 9, 2023 · 2 comments
Assignees
@findleyr
Labels
FrozenDueToAge gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.14.0

Comments

@hyangah
Copy link
Contributor

hyangah commented May 9, 2023

golang.org/toolchain/* added for the extended forward compat work are special modules and not suitable for import candidates.
We probably need to exclude them from goimports computation too.

Screenshot 2023-05-08 at 9 22 22 PM
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 9, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 9, 2023
@findleyr
Copy link
Member

findleyr commented May 9, 2023

Thanks for catching this so quickly!

I'm working on goimports, so may do this now, but slotting for v0.13.0 as this is tied to the forward compat work.

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.13.0 May 9, 2023
@adonovan adonovan added the gopls/completion Issues related to auto-completion in gopls. label Aug 31, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/531417 mentions this issue: gopls/internal/lsp/source: don't complete to golang.org/toolchain

@findleyr findleyr self-assigned this Sep 27, 2023
@golang golang locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.14.0
Development

No branches or pull requests
4 participants
@hyangah @adonovan @gopherbot @findleyr