Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/unitchecker: TestVetStdlib failures #60058

Open
gopherbot opened this issue May 8, 2023 · 16 comments
Open

x/tools/go/analysis/unitchecker: TestVetStdlib failures #60058

gopherbot opened this issue May 8, 2023 · 16 comments
Assignees
@adonovan
Labels
NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestVetStdlib (35.36s)
    vet_std_test.go:95: go vet std failed (exit status 1):
        # fmt_test
        /tmp/workdir/go/src/fmt/fmt_test.go:1241:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1249:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1257:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1265:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1274:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1282:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1290:11: result of fmt.Sprintf call not used
...
        /tmp/workdir/go/src/fmt/fmt_test.go:1437:42: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1438:39: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1776:9: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1782:9: result of fmt.Sprintf call not used
        # context_test
        /tmp/workdir/go/src/context/x_test.go:524:47: result of context.WithValue call not used
        /tmp/workdir/go/src/context/x_test.go:528:46: result of context.WithValue call not used
        /tmp/workdir/go/src/context/x_test.go:535:48: result of context.WithCancel call not used
        /tmp/workdir/go/src/context/x_test.go:539:49: result of context.WithDeadline call not used
        /tmp/workdir/go/src/context/x_test.go:543:46: result of context.WithValue call not used

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 8, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2023-05-08 19:51 linux-arm64-longtest tools@8f7fb01d go@4576184b x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (35.36s)
    vet_std_test.go:95: go vet std failed (exit status 1):
        # fmt_test
        /tmp/workdir/go/src/fmt/fmt_test.go:1241:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1249:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1257:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1265:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1274:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1282:11: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1290:11: result of fmt.Sprintf call not used
...
        /tmp/workdir/go/src/fmt/fmt_test.go:1437:42: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1438:39: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1776:9: result of fmt.Sprintf call not used
        /tmp/workdir/go/src/fmt/fmt_test.go:1782:9: result of fmt.Sprintf call not used
        # context_test
        /tmp/workdir/go/src/context/x_test.go:524:47: result of context.WithValue call not used
        /tmp/workdir/go/src/context/x_test.go:528:46: result of context.WithValue call not used
        /tmp/workdir/go/src/context/x_test.go:535:48: result of context.WithCancel call not used
        /tmp/workdir/go/src/context/x_test.go:539:49: result of context.WithDeadline call not used
        /tmp/workdir/go/src/context/x_test.go:543:46: result of context.WithValue call not used

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 8, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 8, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2023-05-08 19:51 linux-386-longtest tools@8f7fb01d go@4576184b x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (64.02s)
    vet_std_test.go:95: go vet std failed (exit status 1):
        # fmt_test
        /workdir/go/src/fmt/fmt_test.go:1241:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1249:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1257:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1265:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1274:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1282:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1290:11: result of fmt.Sprintf call not used
...
        /workdir/go/src/fmt/fmt_test.go:1437:42: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1438:39: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1776:9: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1782:9: result of fmt.Sprintf call not used
        # context_test
        /workdir/go/src/context/x_test.go:524:47: result of context.WithValue call not used
        /workdir/go/src/context/x_test.go:528:46: result of context.WithValue call not used
        /workdir/go/src/context/x_test.go:535:48: result of context.WithCancel call not used
        /workdir/go/src/context/x_test.go:539:49: result of context.WithDeadline call not used
        /workdir/go/src/context/x_test.go:543:46: result of context.WithValue call not used
2023-05-08 19:51 linux-amd64-longtest tools@8f7fb01d go@4576184b x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (62.57s)
    vet_std_test.go:95: go vet std failed (exit status 1):
        # fmt_test
        /workdir/go/src/fmt/fmt_test.go:1241:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1249:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1257:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1265:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1274:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1282:11: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1290:11: result of fmt.Sprintf call not used
...
        /workdir/go/src/fmt/fmt_test.go:1437:42: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1438:39: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1776:9: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1782:9: result of fmt.Sprintf call not used
        # context_test
        /workdir/go/src/context/x_test.go:524:47: result of context.WithValue call not used
        /workdir/go/src/context/x_test.go:528:46: result of context.WithValue call not used
        /workdir/go/src/context/x_test.go:535:48: result of context.WithCancel call not used
        /workdir/go/src/context/x_test.go:539:49: result of context.WithDeadline call not used
        /workdir/go/src/context/x_test.go:543:46: result of context.WithValue call not used
2023-05-08 19:51 linux-amd64-longtest-race tools@8f7fb01d go@4576184b x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (123.13s)
    vet_std_test.go:95: go vet std failed (exit status 1):
        # context_test
        /workdir/go/src/context/x_test.go:524:47: result of context.WithValue call not used
        /workdir/go/src/context/x_test.go:528:46: result of context.WithValue call not used
        /workdir/go/src/context/x_test.go:535:48: result of context.WithCancel call not used
        /workdir/go/src/context/x_test.go:539:49: result of context.WithDeadline call not used
        /workdir/go/src/context/x_test.go:543:46: result of context.WithValue call not used
        # fmt_test
        /workdir/go/src/fmt/fmt_test.go:1241:11: result of fmt.Sprintf call not used
...
        /workdir/go/src/fmt/fmt_test.go:1431:37: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1432:40: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1433:39: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1434:39: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1435:44: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1436:39: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1437:42: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1438:39: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1776:9: result of fmt.Sprintf call not used
        /workdir/go/src/fmt/fmt_test.go:1782:9: result of fmt.Sprintf call not used
2023-05-08 19:51 windows-amd64-longtest tools@8f7fb01d go@4576184b x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (74.61s)
    vet_std_test.go:95: go vet std failed (exit status 1):
        # context_test
        C:\workdir\go\src\context\x_test.go:524:47: result of context.WithValue call not used
        C:\workdir\go\src\context\x_test.go:528:46: result of context.WithValue call not used
        C:\workdir\go\src\context\x_test.go:535:48: result of context.WithCancel call not used
        C:\workdir\go\src\context\x_test.go:539:49: result of context.WithDeadline call not used
        C:\workdir\go\src\context\x_test.go:543:46: result of context.WithValue call not used
        # fmt_test
        C:\workdir\go\src\fmt\fmt_test.go:1241:11: result of fmt.Sprintf call not used
...
        C:\workdir\go\src\fmt\fmt_test.go:1431:37: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1432:40: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1433:39: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1434:39: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1435:44: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1436:39: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1437:42: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1438:39: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1776:9: result of fmt.Sprintf call not used
        C:\workdir\go\src\fmt\fmt_test.go:1782:9: result of fmt.Sprintf call not used

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2023-05-08 19:51 darwin-amd64-longtest tools@8f7fb01d go@4576184b x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (261.41s)
    vet_std_test.go:95: go vet std failed (exit status 1):
        # context_test
        /tmp/buildlet/go/src/context/x_test.go:524:47: result of context.WithValue call not used
        /tmp/buildlet/go/src/context/x_test.go:528:46: result of context.WithValue call not used
        /tmp/buildlet/go/src/context/x_test.go:535:48: result of context.WithCancel call not used
        /tmp/buildlet/go/src/context/x_test.go:539:49: result of context.WithDeadline call not used
        /tmp/buildlet/go/src/context/x_test.go:543:46: result of context.WithValue call not used
        # fmt_test
        /tmp/buildlet/go/src/fmt/fmt_test.go:1241:11: result of fmt.Sprintf call not used
...
        /tmp/buildlet/go/src/fmt/fmt_test.go:1431:37: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1432:40: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1433:39: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1434:39: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1435:44: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1436:39: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1437:42: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1438:39: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1776:9: result of fmt.Sprintf call not used
        /tmp/buildlet/go/src/fmt/fmt_test.go:1782:9: result of fmt.Sprintf call not used

— watchflakes

@adonovan adonovan self-assigned this May 8, 2023
@adonovan
Copy link
Member

adonovan commented May 8, 2023

This was fixed on master thanks to Russ's https://go.dev/cl/493598.

@adonovan adonovan closed this as completed May 8, 2023
@heschi
Copy link
Contributor

heschi commented Jun 21, 2023

@gopherbot please backport to 1.20.

@gopherbot gopherbot mentioned this issue Jun 21, 2023
Closed
@gopherbot
Copy link
Author

Backport issue(s) opened: #60927 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@gopherbot
Copy link
Author

Change https://go.dev/cl/504977 mentions this issue: [release-branch.go1.20] all: make safe for new vet analyzer

gopherbot pushed a commit that referenced this issue Jun 21, 2023
@heschi @gopherbot
[release-branch.go1.20] all: make safe for new vet analyzer
c32f1af 
The unused analyzer handles dot imports now, so a few tests
have picked up vet errors. This CL errors like:

context/x_test.go:524:47: result of context.WithValue call not used

This is a manual cherry-pick of CL 493598.

Updates #60058
Fixes #60927

Change-Id: I92906ef7967e14a85fa974e6307fd689e3ff3dba
Reviewed-on: https://go-review.googlesource.com/c/go/+/504977
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Bypass: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot gopherbot reopened this Jan 5, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2024-01-05 17:34 linux-386-longtest tools@ba8672b5 go@c0693f64 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (71.61s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 linux-386-longtest tools@ba8672b5 go@8db13108 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (73.91s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 linux-amd64-longtest tools@ba8672b5 go@c0693f64 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (72.92s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 linux-amd64-longtest tools@ba8672b5 go@8db13108 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (68.08s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 linux-arm64-longtest tools@ba8672b5 go@c0693f64 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (39.80s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /tmp/workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /tmp/workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /tmp/workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /tmp/workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /tmp/workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /tmp/workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 linux-arm64-longtest tools@ba8672b5 go@8db13108 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (39.88s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /tmp/workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /tmp/workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /tmp/workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /tmp/workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /tmp/workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /tmp/workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2024-01-05 17:34 linux-amd64-longtest-race tools@ba8672b5 go@c0693f64 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (114.65s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 linux-amd64-longtest-race tools@ba8672b5 go@8db13108 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (114.28s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /workdir/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /workdir/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /workdir/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /workdir/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 windows-amd64-longtest tools@ba8672b5 go@c0693f64 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (84.29s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        C:\workdir\go\src\slices\slices_test.go:560:29: result of slices.Insert call not used
        C:\workdir\go\src\slices\slices_test.go:687:29: result of slices.Delete call not used
        C:\workdir\go\src\slices\slices_test.go:909:49: result of slices.Grow call not used
        C:\workdir\go\src\slices\slices_test.go:912:49: result of slices.Grow call not used
        C:\workdir\go\src\slices\slices_test.go:924:7: result of slices.Grow call not used
        C:\workdir\go\src\slices\slices_test.go:1040:30: result of slices.Replace call not used
2024-01-05 17:34 windows-amd64-longtest tools@ba8672b5 go@8db13108 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (77.08s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        C:\workdir\go\src\slices\slices_test.go:560:29: result of slices.Insert call not used
        C:\workdir\go\src\slices\slices_test.go:687:29: result of slices.Delete call not used
        C:\workdir\go\src\slices\slices_test.go:909:49: result of slices.Grow call not used
        C:\workdir\go\src\slices\slices_test.go:912:49: result of slices.Grow call not used
        C:\workdir\go\src\slices\slices_test.go:924:7: result of slices.Grow call not used
        C:\workdir\go\src\slices\slices_test.go:1040:30: result of slices.Replace call not used

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2024-01-05 17:34 darwin-amd64-longtest tools@ba8672b5 go@8db13108 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
--- FAIL: TestVetStdlib (323.53s)
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        /tmp/buildlet/go/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        /tmp/buildlet/go/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        /tmp/buildlet/go/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        /tmp/buildlet/go/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        /tmp/buildlet/go/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        /tmp/buildlet/go/src/slices/slices_test.go:1040:30: result of slices.Replace call not used

— watchflakes

@dmitshur
Copy link
Contributor

dmitshur commented Jan 8, 2024 •
edited

Longtest builders are failing on 1.21 and 1.22 release branches (but not on tip and 1.20 release branch):

https://ci.chromium.org/p/golang/g/x-tools-go1.21/console
https://ci.chromium.org/p/golang/g/x-tools-go1.22/console

Since it's affecting first-class ports, it's blocking the monthly tagging workflow. Adding Soon label.

Mailed CL 554755 to pull in the change made in CL 554196 into release-branch.go1.22.
Mailed CL 554756 to backport the change in CL 554196 to release branch.go1.21.
(CC @adonovan.)

@dmitshur dmitshur added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Jan 8, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/554756 mentions this issue: [release-branch.go1.21] slices: explicitly discard results of some functions

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 8, 2024
gopherbot pushed a commit that referenced this issue Jan 10, 2024
@adonovan @gopherbot
[release-branch.go1.21] slices: explicitly discard results of some fu…
2540b14 
…nctions

This will otherwise trigger an "unusedresult" vet check.

For #64978.
Fixes #65023.
Fixes #60058.

Change-Id: Ie19aded0f808d394f389452c3ff7f3edc1ed710d
Reviewed-on: https://go-review.googlesource.com/c/go/+/554196
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 8088b6d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/554756
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@dmitshur
Copy link
Contributor

The instance reported 5 days ago is fixed by the CLs mentioned above; closing.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2024-01-05 17:34 x_tools-gotip-darwin-amd64-longtest tools@ba8672b5 go@8db13108 x/tools/go/analysis/unitchecker.TestVetStdlib (log) 
=== RUN   TestVetStdlib
    vet_std_test.go:99: go vet std failed (exit status 1):
        # slices_test
        # [slices_test]
        ../../../../goroot/src/slices/slices_test.go:560:29: result of slices.Insert call not used
        ../../../../goroot/src/slices/slices_test.go:687:29: result of slices.Delete call not used
        ../../../../goroot/src/slices/slices_test.go:909:49: result of slices.Grow call not used
        ../../../../goroot/src/slices/slices_test.go:912:49: result of slices.Grow call not used
        ../../../../goroot/src/slices/slices_test.go:924:7: result of slices.Grow call not used
        ../../../../goroot/src/slices/slices_test.go:1040:30: result of slices.Replace call not used
--- FAIL: TestVetStdlib (198.74s)

— watchflakes

@dmitshur
Copy link
Contributor

The report 1 hr ago (#60058 (comment)) is the same Go commit and x/tools commit as the earlier one (#60058 (comment)). The difference is it came from LUCI builders instead of old builders.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/analysis/unitchecker" && test == "TestVetStdlib"
2024-02-16 15:54 x_tools-gotip-darwin-amd64-longtest tools@0d171942 go@86a32d6d x/tools/go/analysis/unitchecker.TestVetStdlib [ABORT] (log) 
=== RUN   TestVetStdlib
panic: test timed out after 10m0s
running tests:
	TestVetStdlib (9m41s)

goroutine 119 [running]:
testing.(*M).startAlarm.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2366 +0x385
created by time.goFunc
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/time/sleep.go:177 +0x2d
...
io.copyBuffer({0x65d6a78, 0xc000381020}, {0x65d69d8, 0xc000130368}, {0x0, 0x0, 0x0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/io/io.go:411 +0x9d
io.Copy(...)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/io/io.go:388
os/exec.(*Cmd).writerDescriptor.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/os/exec/exec.go:577 +0x20
os/exec.(*Cmd).Start.func2(0x65d4550?)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/os/exec/exec.go:724 +0x2c
created by os/exec.(*Cmd).Start in goroutine 148
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/os/exec/exec.go:723 +0x9ab

— watchflakes

@gopherbot gopherbot reopened this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @adonovan @gopherbot @heschi