Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/relui: failed tasks waiting on approval show "pending" state, instead of "failed" with retry button available #60054

Open
dmitshur opened this issue May 8, 2023 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 8, 2023

We observed recently that when a task that is waiting on release coordinator approval happens to fail (e.g., due to a database maintenance window lasting longer than it takes for the 3 retries to get used up), the UI gets into a confusing state.

It will continue to show the failed task with a "pending" state and an "approve" button. It's better if it would begin to show "failed" state and "retry" button. It shows correct state after relui is restarted, which can be used as a workaround.

This is the tracking issue to make it unnecessary to restart in that situation (as rare as it might be).

CC @golang/release.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 8, 2023
@dmitshur dmitshur added this to the Unreleased milestone May 8, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants