Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/lsprpc: TestClientLoggingV2 failures #60021

Closed
gopherbot opened this issue May 6, 2023 · 4 comments
Closed

x/tools/gopls/internal/lsp/lsprpc: TestClientLoggingV2 failures #60021

gopherbot opened this issue May 6, 2023 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/lsprpc" && test == "TestClientLoggingV2"

Issue created automatically to collect these failures.

Example (log):

2023/05/06 21:17:35 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-riscv64-unmatched/tmp/go-build1086631972/b484/lsprpc.test"
	client_id="3"
2023/05/06 21:17:35 forwarder: exited with error: client disconnected: io: read/write on closed pipe
2023/05/06 21:17:40 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-riscv64-unmatched/tmp/go-build1086631972/b484/lsprpc.test"
	client_id="6"
2023/05/06 21:17:41 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:40578->127.0.0.1:51822: use of closed network connection
2023/05/06 21:17:41 ping
2023/05/06 21:17:42 ping
--- FAIL: TestClientLoggingV2 (1.26s)
    --- FAIL: TestClientLoggingV2/forwarded (1.25s)
        binder_test.go:104: timeout waiting for client log

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 6, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/lsprpc" && test == "TestClientLoggingV2"
2023-05-05 23:11 freebsd-riscv64-unmatched tools@479f5c69 go@05ca41d3 x/tools/gopls/internal/lsp/lsprpc.TestClientLoggingV2 (log) 
2023/05/06 21:17:35 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-riscv64-unmatched/tmp/go-build1086631972/b484/lsprpc.test"
	client_id="3"
2023/05/06 21:17:35 forwarder: exited with error: client disconnected: io: read/write on closed pipe
2023/05/06 21:17:40 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-riscv64-unmatched/tmp/go-build1086631972/b484/lsprpc.test"
	client_id="6"
2023/05/06 21:17:41 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:40578->127.0.0.1:51822: use of closed network connection
2023/05/06 21:17:41 ping
2023/05/06 21:17:42 ping
--- FAIL: TestClientLoggingV2 (1.26s)
    --- FAIL: TestClientLoggingV2/forwarded (1.25s)
        binder_test.go:104: timeout waiting for client log

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 6, 2023
@findleyr
Copy link
Contributor

findleyr commented May 9, 2023

Given that this package will (hopefully) be deprecated soon, I'm going to close this in hopes that it is a brief network issue on the builder.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2023
@gopherbot gopherbot reopened this Sep 8, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/lsprpc" && test == "TestClientLoggingV2"
2023-09-07 17:02 freebsd-riscv64-unmatched tools@b0cdf010 go@2f0b28da x/tools/gopls/internal/lsp/lsprpc.TestClientLoggingV2 (log) 
2023/09/08 18:15:18 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-riscv64-unmatched/tmp/go-build3857717780/b511/lsprpc.test"
	client_id="3"
2023/09/08 18:15:18 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:23392->127.0.0.1:53017: use of closed network connection
2023/09/08 18:15:26 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-riscv64-unmatched/tmp/go-build3857717780/b511/lsprpc.test"
	client_id="6"
2023/09/08 18:15:26 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:51505->127.0.0.1:41957: use of closed network connection
2023/09/08 18:15:26 ping
2023/09/08 18:15:29 ping
--- FAIL: TestClientLoggingV2 (2.03s)
    --- FAIL: TestClientLoggingV2/forwarded (1.35s)
        binder_test.go:104: timeout waiting for client log

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Sep 8, 2023

Still not worth tracking this.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr