Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/envcmd: FuzzPrintEnvEscape failures #59998

Closed
gopherbot opened this issue May 5, 2023 · 12 comments
Closed

cmd/go/internal/envcmd: FuzzPrintEnvEscape failures #59998

gopherbot opened this issue May 5, 2023 · 12 comments
Assignees
@matloob
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "cmd/go/internal/envcmd" && test == "FuzzPrintEnvEscape"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#1 (0.02s)
        env_test.go:76: var='$(echo shell expansion 1>&2)'
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 5, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/envcmd" && test == "FuzzPrintEnvEscape"
2023-05-05 14:28 freebsd-amd64-12_3 go@f379e789 cmd/go/internal/envcmd.FuzzPrintEnvEscape (log) 
--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#1 (0.02s)
        env_test.go:76: var='$(echo shell expansion 1>&2)'
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/envcmd" && test == "FuzzPrintEnvEscape"
2023-05-05 14:37 freebsd-amd64-13_0 go@72c33a5e cmd/go/internal/envcmd.FuzzPrintEnvEscape (log) 
--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#11 (0.01s)
        env_test.go:76: var='E,%'
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126
2023-05-05 14:54 freebsd-amd64-12_3 go@574431cf cmd/go/internal/envcmd.FuzzPrintEnvEscape (log) 
--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#8 (0.02s)
        env_test.go:76: var=''\'''\'''\'''\'''\'''\'''\'''\'''
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/envcmd" && test == "FuzzPrintEnvEscape"
2023-05-05 15:03 freebsd-amd64-12_3 go@761e8138 cmd/go/internal/envcmd.FuzzPrintEnvEscape (log) 
--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#2 (0.02s)
        env_test.go:76: var=''\'''\'''
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126

— watchflakes

@bcmills bcmills added GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure. labels May 5, 2023
@bcmills bcmills added this to the Go1.21 milestone May 5, 2023
@bcmills
Copy link
Contributor

bcmills commented May 5, 2023

This may be a variation on #22315. I suggest that we modify the test to pass the script directly to sh -c instead of writing it to a separate script.sh file and see if that fixes it.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/envcmd" && test == "FuzzPrintEnvEscape"
2023-05-05 19:07 freebsd-amd64-13_0 go@26899ef3 cmd/go/internal/envcmd.FuzzPrintEnvEscape (log) 
--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#8 (0.02s)
        env_test.go:76: var=''\'''\'''\'''\'''\'''\'''\'''\'''
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126
    --- FAIL: FuzzPrintEnvEscape/seed#9 (0.02s)
        env_test.go:76: var=''
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126

— watchflakes

@aclements
Copy link
Member

This is causing a lot of trybot failures for me:

https://storage.googleapis.com/go-build-log/8d4309b8/freebsd-amd64-12_3_5dbb6261.log
https://storage.googleapis.com/go-build-log/e6b52fd6/freebsd-amd64-12_3_9926e942.log
https://storage.googleapis.com/go-build-log/4f8c8fb4/freebsd-amd64-12_3_990bd5cf.log
https://storage.googleapis.com/go-build-log/4193b6ab/freebsd-amd64-12_3_2669a3b9.log

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/envcmd" && test == "FuzzPrintEnvEscape"
2023-05-08 13:37 freebsd-amd64-13_0 go@9fa81a88 cmd/go/internal/envcmd.FuzzPrintEnvEscape (log) 
--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#3 (0.01s)
        env_test.go:76: var='C:\"Program Files"\'
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126

— watchflakes

@prattmic
Copy link
Member

prattmic commented May 8, 2023

TryBot failures for me too:

https://storage.googleapis.com/go-build-log/71a7e610/freebsd-amd64-12_3_94d04626.log

cc @matloob

@gopherbot
Copy link
Author

Change https://go.dev/cl/493555 mentions this issue: cmd/go/internal/envcmd: on unix pass script contents directly to sh -c

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/envcmd" && test == "FuzzPrintEnvEscape"
2023-05-08 16:50 freebsd-amd64-12_3 go@bc3bdfa9 cmd/go/internal/envcmd.FuzzPrintEnvEscape (log) 
--- FAIL: FuzzPrintEnvEscape (0.00s)
    --- FAIL: FuzzPrintEnvEscape/seed#3 (0.01s)
        env_test.go:76: var='C:\"Program Files"\'
            printf '%s\n' "$var"

        env_test.go:84: 
        env_test.go:86: exit status 126

— watchflakes

gopherbot pushed a commit that referenced this issue May 8, 2023
@matloob
cmd/go/internal/envcmd: on unix pass script contents directly to sh -c
4576184 
Instead of writing them to a file and executing that file.

For #59998

Change-Id: I341786926762359f67dccb475295afbbb8ed1054
Reviewed-on: https://go-review.googlesource.com/c/go/+/493555
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
@bcmills
Copy link
Contributor

bcmills commented May 8, 2023 •
edited

Should have been fixed by CL 493555, if our hypothesis about the cause is correct.

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 8, 2023
@cherrymui
Copy link
Member

Let's assume it is fixed by the CL. If it happens again watchflakes will reopen. Thanks.

@bcmills bcmills removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matloob matloob

Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
6 participants
@prattmic @aclements @bcmills @gopherbot @cherrymui @matloob