Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestConfigDir failures #59985

Open
gopherbot opened this issue May 4, 2023 · 3 comments
Open

x/tools/go/packages: TestConfigDir failures #59985

gopherbot opened this issue May 4, 2023 · 3 comments
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestConfigDir"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestConfigDir (0.00s)
    --- FAIL: TestConfigDir/Modules (134.14s)
        packages_test.go:481: dir "/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestConfigDir_Modules2691312952/fake", pattern "./b": got , want "b"
        packages_test.go:490: dir "/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestConfigDir_Modules2691312952/fake", pattern "./b": error true, want false

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels May 4, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestConfigDir"
2023-05-03 16:13 solaris-amd64-oraclerel tools@7df6af86 go@324c3ace x/tools/go/packages.TestConfigDir (log) 
--- FAIL: TestConfigDir (0.00s)
    --- FAIL: TestConfigDir/Modules (134.14s)
        packages_test.go:481: dir "/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestConfigDir_Modules2691312952/fake", pattern "./b": got , want "b"
        packages_test.go:490: dir "/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestConfigDir_Modules2691312952/fake", pattern "./b": error true, want false

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 15, 2023

This is not a useful test failure.

Probably a good first step would be to update the test to log the error returned by packages.Load.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted labels Nov 15, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestConfigDir"
2024-02-02 16:43 x_tools-go1.22-linux-arm tools@85146f5b release-branch.go1.22@b0957cfc x/tools/go/packages.TestConfigDir (log) 
=== RUN   TestConfigDir/Modules
=== PAUSE TestConfigDir/Modules
=== CONT  TestConfigDir/Modules
    invoke.go:268: 19.523278ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/b go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 69.87219ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/b go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 73.411649ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/b go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- golang.org/fake/a
    packages_test.go:480: dir "/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/b", pattern "golang.org/fake/a": got , want "a"
    invoke.go:268: 61.545244ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/b go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 69.614888ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/b go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 36.773618ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/b go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- golang.org/fake/b
...
    invoke.go:268: 46.374455ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- golang.org/fake/b
    packages_test.go:480: dir "/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a", pattern "golang.org/fake/b": got , want "b"
    invoke.go:268: 64.165689ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 108.830664ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 112.10629ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- ./a
    invoke.go:268: 76.310606ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 40.180697ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 31.579711ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- ./b
    packages_test.go:480: dir "/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules4026140308/fake/a", pattern "./b": got , want "a/b"
--- FAIL: TestConfigDir/Modules (1.15s)
2024-02-02 16:43 x_tools-gotip-linux-arm tools@85146f5b go@3b83560b x/tools/go/packages.TestConfigDir (log) 
=== RUN   TestConfigDir/Modules
=== PAUSE TestConfigDir/Modules
=== CONT  TestConfigDir/Modules
    invoke.go:268: 6.699294ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/b go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 8.541491ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/b go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 43.508163ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/b go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- golang.org/fake/a
    invoke.go:268: 21.567539ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/b go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 27.197463ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/b go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 82.728148ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/b go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- golang.org/fake/b
    invoke.go:268: 18.760726ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/b go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
...
    invoke.go:268: 28.418447ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 11.265401ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- golang.org/fake/b
    invoke.go:268: 17.143102ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 32.424797ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 63.368765ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- ./a
    invoke.go:268: 15.411517ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -e -f {{context.ReleaseTags}} -- unsafe
    invoke.go:268: 15.581181ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
    invoke.go:268: 25.340342ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=true -test=true -export=true -deps=true -find=false -pgo=off -- ./b
    packages_test.go:480: dir "/home/swarming/.swarming/w/ir/x/t/TestConfigDir_Modules1413915871/fake/a", pattern "./b": got , want "a/b"
--- FAIL: TestConfigDir/Modules (0.83s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: No status
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot