Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: git http-backend on linux-loong64-3a5000 fails with GIT_PROJECT_ROOT is set but PATH_INFO is not #59984

Closed
bcmills opened this issue May 4, 2023 · 7 comments
Labels
arch-loong64 Issues solely affecting the loongson architecture. Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented May 4, 2023

The linux-loong64-3a5000 builder started failing as of https://go.dev/cl/491659.
https://build.golang.org/log/2c3437d386796f3252381ab1d3ed9051681bf513:

# get http://127.0.0.1:34721/git/gitrepo1
fatal: GIT_PROJECT_ROOT is set but PATH_INFO is not
# get http://127.0.0.1:34721/git/gitrepo1: 500 Internal Server Error (0.052s)

The HTTP handler is run using a net/http/cgi.Handler via cmd/go/internal/vcweb:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/vcweb/git.go;l=40-49;drc=57f9ed5f12ba395fa55880305bc11e1db840f36c

The cgi.Handler unconditionally sets PATH_INFO:
https://cs.opensource.google/go/go/+/master:src/net/http/cgi/host.go;l=118-147;drc=ffa663c9b3c942cbde590bb792179dcca52224b7

So this looks like a bug on loong64 where either that environment variable is not being passed to the git command correctly, or the git command is not reading it correctly.

(attn @golang/loong64)

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 4, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 4, 2023
@bcmills bcmills added the arch-loong64 Issues solely affecting the loongson architecture. label May 4, 2023
@bcmills bcmills modified the milestones: Unreleased, Backlog May 4, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/492716 mentions this issue: cmd/go/internal/modfetch/codehost: skip repo tests on linux-loong64-3a5000

@abner-chenc
Copy link
Contributor

Sorry, this error is because the environment variable is set on the builder of loong64 “http_proxy” caused it, I'll deal with it right away.

@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label May 5, 2023
@bcmills
Copy link
Contributor Author

bcmills commented May 12, 2023

Looks like this is now fixed?

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 12, 2023
@abner-chenc
Copy link
Contributor

Looks like this is now fixed?

Yes, I think the problem has been fixed now.

@npadhya
Copy link

npadhya commented Jun 6, 2023

Can someone please attach the PR that fixed it?

@xen0n
Copy link
Member

xen0n commented Jun 6, 2023

Can someone please attach the PR that fixed it?

Hi; I believe this is solely a builder configuration problem, so there was no code change. @abner-chenc can confirm that as the maintainer of the builder.

@gopherbot
Copy link
Contributor

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-loong64 Issues solely affecting the loongson architecture. Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

6 participants