Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: git commands broken on android-.*-corellium builders due to missing libssl.so.1.1 #59940

Open
bcmills opened this issue May 3, 2023 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented May 3, 2023

https://storage.googleapis.com/go-build-log/d11befbe/android-arm64-corellium_c80dd207.log:

--- FAIL: TestLatest (0.01s)
    git_test.go:69: git clone --mirror http://127.0.0.1:40864/git/gitrepo1 /data/data/com.termux/files/home/tmpdir/workdir-host-android-arm64-corellium-android/tmp/gitrepo-test-4244768098/gitrepo2 in : exit status 128:
        	Cloning into bare repository '/data/data/com.termux/files/home/tmpdir/workdir-host-android-arm64-corellium-android/tmp/gitrepo-test-4244768098/gitrepo2'...
        	CANNOT LINK EXECUTABLE "/data/data/com.termux/files/usr/libexec/git-core/git-remote-http": library "libssl.so.1.1" not found
    --- FAIL: TestLatest/gitrepo1 (0.00s)
        git_test.go:226: git ls-remote -q origin in /data/data/com.termux/files/home/tmpdir/workdir-host-android-arm64-corellium-android/tmp/gitrepo-test-4244768098/modcache/cache/vcs/8c0735055ea1b81d6712e25976d1c2026f3fc83f00c38628a1134f3cd92a54d2: exit status 128:
            	CANNOT LINK EXECUTABLE "/data/data/com.termux/files/usr/libexec/git-core/git-remote-http": library "libssl.so.1.1" not found
FAIL
FAIL	cmd/go/internal/modfetch/codehost	1.659s

(and many more like it!)

@changkun, I think this is a configuration problem in the builder. The fix is probably one of:

  • install libssl in the termux environment, or
  • set LD_LIBRARY_PATH so that the dynamic linker can find libssl.so.1.1, or
  • remove git from the termux environment or $PATH (so that we skip tests that would need it).bui
@bcmills bcmills added Builders x/build issues (builders, bots, dashboards) OS-Android NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 3, 2023
@bcmills bcmills added this to the Backlog milestone May 3, 2023
@gopherbot
Copy link

Change https://go.dev/cl/491659 mentions this issue: cmd/go/internal/modfetch/codehost: initialize localGitURL lazily and clean up skips

gopherbot pushed a commit that referenced this issue May 4, 2023
…clean up skips

Previously localGitURL was initialized in TestMain, which creates
needless work if the test flags do not result in running a test that
requires localGitURL.

We had also been skipping a bunch of tests that used
vcs-test.golang.org in order to avoid network traffic, but now that
that content is served through an in-process vcweb server that is no
longer necessary. (All of the 'git' tests together take less than a
second to run.)

The 'hg' tests are much slower, so we do still skip those in short
mode.

Updates #59940.

Change-Id: Ie4f2d2bc825d7a011e25e754edf1a7c3c6010c77
Reviewed-on: https://go-review.googlesource.com/c/go/+/491659
Reviewed-by: Michael Matloob <matloob@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Projects
None yet
Development

No branches or pull requests

2 participants