Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: update fixed version to take in account multiple modules #59931

Closed
julieqiu opened this issue May 2, 2023 · 1 comment
Closed

x/vuln: update fixed version to take in account multiple modules #59931

julieqiu opened this issue May 2, 2023 · 1 comment
Assignees
@tatianab
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/v0.2.0

Comments

@julieqiu
Copy link
Member

julieqiu commented May 2, 2023

https://github.com/golang/vuln/blob/1558849bf5f5be22c9826be5349d01b6fdacb316/internal/scan/util.go#L124 should take into account the module path

https://github.com/golang/vuln/blob/1558849bf5f5be22c9826be5349d01b6fdacb316/internal/scan/util.go#L149
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label May 2, 2023
@julieqiu julieqiu added this to the vuln/v0.2.0 milestone May 2, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/491662 mentions this issue: internal/scan: update latestFixed to consider multi-module case

gopherbot pushed a commit to golang/vuln that referenced this issue May 10, 2023
@tatianab
internal/scan: update latestFixed to consider multi-module case

Verified

This commit was signed with the committer’s verified signature.
a1346054
GPG key ID: D149AD21DC40440C
Verified
Learn about vigilant mode
d80aabf 
The function latestFixed now works with respect to a single module,
instead of finding the overall latest fixed version in an affected list.

Fixes golang/go#59931

Change-Id: If127ee07aadb94ebd17536f9ff57362585ca9ea4
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/491662
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tatianab tatianab

Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/v0.2.0
Development

No branches or pull requests
3 participants
@julieqiu @tatianab @gopherbot