Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: create system test for blocking profile #5993

Closed
dvyukov opened this issue Jul 30, 2013 · 4 comments
Closed

runtime/pprof: create system test for blocking profile #5993

dvyukov opened this issue Jul 30, 2013 · 4 comments
Milestone

Comments

@dvyukov
Copy link
Member

dvyukov commented Jul 30, 2013

Nobody knows whether it's working now or not.
Ideally the test must do end-to-end testing: build test, run test, run pprof, ensure
that the output is correct.
Similar tests are needed to CPU/memory profiler as well.
@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 3:

Labels changed: added feature.

@dvyukov
Copy link
Member Author

dvyukov commented Aug 8, 2013

Comment 4:

Does label:Feature means that it must be done before feature freeze?
If so, I would expect adding tests to be a good task for feature freeze.

@rsc
Copy link
Contributor

rsc commented Aug 8, 2013

Comment 5:

As long as the test does not involve changes to the runtime, it is fine to do after the
freeze.

Labels changed: removed feature.

@dvyukov
Copy link
Member Author

dvyukov commented Aug 11, 2013

Comment 6:

This issue was closed by revision 2758101.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants