Change https://go.dev/cl/491375 mentions this issue: go/packages: include "unsafe".GoFiles=["unsafe.go"]

On the cmd/go side, I see:

~$ gotip list -json unsafe
{
        "Dir": "/usr/local/google/home/bcmills/sdk/gotip/src/unsafe",
        "ImportPath": "unsafe",
        "Name": "unsafe",
        "Doc": "Package unsafe contains operations that step around the type safety of Go programs.",
        "Root": "/usr/local/google/home/bcmills/sdk/gotip",
        "Match": [
                "unsafe"
        ],
        "Goroot": true,
        "Standard": true,
        "GoFiles": [
                "unsafe.go"
        ]
}

But perhaps we should be reporting unsafe.go in IgnoredGoFiles instead, since we don't actually present that file to the compiler in order to build the package? (I'm not sure.)

But perhaps we should be reporting unsafe.go in IgnoredGoFiles instead, since we don't actually present that file to the compiler in order to build the package? (I'm not sure.)

I'm not sure either. IgnoredGoFiles says it's for "files that might be part of the package using other build configurations" and are thus valid syntax, whereas GoFiles (as a matter of fact---it's not documented) holds the cgo source files, which are not really valid Go syntax. So I think GoFiles may be a better fit.

IgnoredGoFiles is not necessarily valid syntax for the Go version in current use.

(For example, the files could contain //go:build go1.24 constraints, in which case they would be syntactically valid for Go 1.24 but not necessarily for Go 1.20.)

True. But the unsafe.go and builtin.go source files are never supposed to be seen by the compiler.