Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/coverage: TestIssue59563TruncatedCoverPkgAll failures #59867

Closed
gopherbot opened this issue Apr 27, 2023 · 8 comments
Closed

runtime/coverage: TestIssue59563TruncatedCoverPkgAll failures #59867

gopherbot opened this issue Apr 27, 2023 · 8 comments
Assignees
@thanm
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "runtime/coverage" && test == "TestIssue59563TruncatedCoverPkgAll"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestIssue59563TruncatedCoverPkgAll (8.92s)
    emitdata_test.go:536: wanted 100.0% got: "runtime/coverage/testdata/issue59563/repro.go:12:\t\t\t\tsmall\t\t\t\t\t50.0%"
    emitdata_test.go:545: func output:
        bufio/bufio.go:47:								NewReaderSize				0.0%
        bufio/bufio.go:62:								NewReader				0.0%
        bufio/bufio.go:67:								Size					0.0%
        bufio/bufio.go:74:								Reset					0.0%
        bufio/bufio.go:87:								reset					0.0%
        bufio/bufio.go:99:								fill					0.0%
        bufio/bufio.go:129:								readErr					0.0%
...
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4502:			lookupString				0.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4564:			lookupStringUnsafe			0.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4587:			newNfkcTrie				100.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4592:			lookupValue				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:14:				Reset					0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:20:				Transform				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:42:				flushTransform				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:55:				transform				0.0%
        vendor/golang.org/x/text/unicode/norm/trie.go:36:				lookup					0.0%
        total:										(statements)				8.6%

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 27, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime/coverage" && test == "TestIssue59563TruncatedCoverPkgAll"
2023-04-27 14:07 linux-amd64-longtest go@e8c8b79f runtime/coverage.TestIssue59563TruncatedCoverPkgAll (log) 
--- FAIL: TestIssue59563TruncatedCoverPkgAll (8.92s)
    emitdata_test.go:536: wanted 100.0% got: "runtime/coverage/testdata/issue59563/repro.go:12:\t\t\t\tsmall\t\t\t\t\t50.0%"
    emitdata_test.go:545: func output:
        bufio/bufio.go:47:								NewReaderSize				0.0%
        bufio/bufio.go:62:								NewReader				0.0%
        bufio/bufio.go:67:								Size					0.0%
        bufio/bufio.go:74:								Reset					0.0%
        bufio/bufio.go:87:								reset					0.0%
        bufio/bufio.go:99:								fill					0.0%
        bufio/bufio.go:129:								readErr					0.0%
...
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4502:			lookupString				0.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4564:			lookupStringUnsafe			0.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4587:			newNfkcTrie				100.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4592:			lookupValue				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:14:				Reset					0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:20:				Transform				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:42:				flushTransform				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:55:				transform				0.0%
        vendor/golang.org/x/text/unicode/norm/trie.go:36:				lookup					0.0%
        total:										(statements)				8.6%

— watchflakes

@bcmills bcmills added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 27, 2023
@bcmills
Copy link
Contributor

bcmills commented Apr 27, 2023

(attn @thanm)

@thanm
Copy link
Contributor

thanm commented Apr 27, 2023

This looks like an issue with the test, I'll send a CL.

@thanm thanm self-assigned this Apr 27, 2023
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 28, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime/coverage" && test == "TestIssue59563TruncatedCoverPkgAll"
2023-05-02 15:36 darwin-amd64-longtest go@2d83b646 runtime/coverage.TestIssue59563TruncatedCoverPkgAll (log) 
--- FAIL: TestIssue59563TruncatedCoverPkgAll (39.95s)
    emitdata_test.go:536: wanted 100.0% got: "runtime/coverage/testdata/issue59563/repro.go:12:\t\t\t\tsmall\t\t\t\t\t50.0%"
    emitdata_test.go:545: func output:
        bufio/bufio.go:47:								NewReaderSize				0.0%
        bufio/bufio.go:62:								NewReader				0.0%
        bufio/bufio.go:67:								Size					0.0%
        bufio/bufio.go:74:								Reset					0.0%
        bufio/bufio.go:87:								reset					0.0%
        bufio/bufio.go:99:								fill					0.0%
        bufio/bufio.go:129:								readErr					0.0%
...
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4502:			lookupString				0.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4564:			lookupStringUnsafe			0.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4587:			newNfkcTrie				100.0%
        vendor/golang.org/x/text/unicode/norm/tables13.0.0.go:4592:			lookupValue				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:14:				Reset					0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:20:				Transform				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:42:				flushTransform				0.0%
        vendor/golang.org/x/text/unicode/norm/transform.go:55:				transform				0.0%
        vendor/golang.org/x/text/unicode/norm/trie.go:36:				lookup					0.0%
        total:										(statements)				8.4%

— watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/492175 mentions this issue: runtime/coverage: fix problematic test from issue 59563

gopherbot pushed a commit that referenced this issue May 3, 2023
@thanm @gopherbot
runtime/coverage: fix problematic test from issue 59563
91a716a 
Fix up the coverage testpoint TestIssue59563TruncatedCoverPkgAll
to avoid spurious failures due to racy behavior. Specifically,
we are only interested in verifying coverage for the larger
function of the two in the test package (the smaller one is only
there to trigger additional function registrations while the
test is finalizing the cov data).

Updates #59867.
Updates #59563.

Change-Id: Ibfbbcbf68e0ad7a4d9606cbcfc69d140375c7b87
Reviewed-on: https://go-review.googlesource.com/c/go/+/492175
Run-TryBot: Than McIntosh <thanm@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@thanm
Copy link
Contributor

thanm commented May 5, 2023

This is in theory fixed with https://go.dev/cl/492175 ; leaving open for a while just in case there are still lingering problems.

@bcmills
Copy link
Contributor

bcmills commented Jan 11, 2024

@thanm, it's been quite a while with no new watchflakes reports; do you want to close this as fixed?

@thanm
Copy link
Contributor

thanm commented Jan 11, 2024

Indeed, thanks. Closing out.

@thanm thanm closed this as completed Jan 11, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanm thanm

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @thanm