Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestBuffers_WriteTo failures #59829

Open
gopherbot opened this issue Apr 25, 2023 · 6 comments
Open

net: TestBuffers_WriteTo failures #59829

gopherbot opened this issue Apr 25, 2023 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "net" && test == "TestBuffers_WriteTo"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestBuffers_WriteTo (38.65s)
    --- FAIL: TestBuffers_WriteTo/WriteTo/0 (25.92s)
        writev_test.go:120: dial tcp 127.0.0.1:50922: connect: operation timed out

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 25, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestBuffers_WriteTo"
2023-04-25 14:24 darwin-amd64-13 go@14f833f1 net.TestBuffers_WriteTo (log) 
--- FAIL: TestBuffers_WriteTo (38.65s)
    --- FAIL: TestBuffers_WriteTo/WriteTo/0 (25.92s)
        writev_test.go:120: dial tcp 127.0.0.1:50922: connect: operation timed out

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Apr 27, 2023

(attn @ianlancetaylor @neild)

@bcmills bcmills added this to the Backlog milestone Apr 27, 2023
@ianlancetaylor
Copy link
Contributor

In both cases the timeout is being reported in the call to withTCPConnPair. So this may not have anything to do with TestBuffers_WriteTo as such.

@ianlancetaylor
Copy link
Contributor

This appears to have happened exactly once so far. It seems clearly impossible based on the code, and on the fact that other tests are using withTCPConnPair successfully. Let's see if it happens again.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestBuffers_WriteTo"
2024-02-23 08:34 android-amd64-emu go@ad377e90 net.TestBuffers_WriteTo (log) 
--- FAIL: TestBuffers_WriteTo (0.02s)
    --- FAIL: TestBuffers_WriteTo/WriteTo/1025 (0.00s)
        writev_test.go:118: accept tcp4 127.0.0.1:46781: accept4: bad file descriptor
        writev_test.go:118: dial tcp 127.0.0.1:46781: connect: connection reset by peer

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 23, 2024

That most recent failure was almost certainly #65857.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ianlancetaylor @bcmills @gopherbot