Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: release version v0.12.0 #59818

Closed
11 of 12 tasks
findleyr opened this issue Apr 24, 2023 · 7 comments
Closed
11 of 12 tasks

x/tools/gopls: release version v0.12.0 #59818

findleyr opened this issue Apr 24, 2023 · 7 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Apr 24, 2023

This issue tracks progress toward releasing gopls@v0.12.0. (Note that this release constitutes a major internal change to gopls, and so this issue will remain open for a while, unlike other release tracking issues).

  • create gopls-release-branch.0.12
  • merge master into gopls-release-branch.0.12
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.12.0-pre.1
  • tag gopls/v0.12.0-pre.2
  • tag gopls/v0.12.0-pre.3
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.12.0
  • update dependencies in master for the next release
@findleyr findleyr added this to the gopls/v0.12.0 milestone Apr 24, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 24, 2023
@gopherbot
Copy link

Change https://go.dev/cl/488335 mentions this issue: codereview.cfg: update for gopls-release-branch.0.12

@gopherbot
Copy link

Change https://go.dev/cl/488355 mentions this issue: gopls/internal/lsp/debug: update hard-coded version for v0.12.0

gopherbot pushed a commit to golang/tools that referenced this issue Apr 24, 2023
Updates golang/go#59818

Change-Id: I486ccfb67d4c5c935f1db1fe8d7f9c16fda9d915
Reviewed-on: https://go-review.googlesource.com/c/tools/+/488335
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
gopherbot pushed a commit to golang/tools that referenced this issue Apr 24, 2023
Updates golang/go#59818

Change-Id: I7b17206c97a62a69d045c1067e26b25aa5ecf76c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/488355
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/488415 mentions this issue: gopls: update go.mod for v0.12.0

gopherbot pushed a commit to golang/tools that referenced this issue Apr 24, 2023
Update x/tools version.

Updates golang/go#59818

Change-Id: I5c7866a1d850e48495dddfc7868a6e107ac33f19
Reviewed-on: https://go-review.googlesource.com/c/tools/+/488415
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/495260 mentions this issue: all: merge master (743372f) into gopls-release-branch.0.12

gopherbot pushed a commit to golang/tools that referenced this issue May 16, 2023
For golang/go#59818

Conflicts:

- gopls/go.sum

Merge List:

+ 2023-05-16 743372f gopls/internal/lsp/debug: limit to 100 recent trace entries
+ 2023-05-16 522243a go/ssa/interp: avoid hard-coding GOOS and GOARCH
+ 2023-05-16 a059382 gopls/internal/lsp/cache: fail workspace load on context cancellation
+ 2023-05-16 e5c8d4d gopls/internal/lsp/cache: unexport ValidBuildConfiguration
+ 2023-05-16 f4e8a71 go/ssa: use core type for composite literal addresses
+ 2023-05-16 3b25dbd go/ssa: use core types for array length
+ 2023-05-16 e7048d5 gopls/internal/lsp/filecache: front with a 100MB in-memory LRU cache
+ 2023-05-16 8c0fcd2 gopls/internal/lsp/lru: extract LRU logic to a standalone package
+ 2023-05-16 19d700c go/ssa/interp: use the actual GOOS and GOARCH to interpret tests
+ 2023-05-16 9dcd3d5 gopls/internal/lsp/filecache: limit Get parallelism too
+ 2023-05-16 7f203f0 go/ssa: consolidate use of underlying pointer
+ 2023-05-15 a13793e gopls/internal/lsp: add quick-fixes to manage the go.work file
+ 2023-05-15 12a0517 internal/gcimporter: improve error handling
+ 2023-05-15 5eb1eb9 gopls/internal/lsp/cache: call filecache.Set asynchronously
+ 2023-05-15 35fe77a gopls/internal/lsp/filecache: limit parallelism in Set
+ 2023-05-12 1c9fe3f gopls: improve diagnostics for orphaned files
+ 2023-05-12 ad74ff6 go/gcexportdata: drop support for the ancient binary format
+ 2023-05-11 01128f9 gopls/internal/lsp/source: fix bug renaming field to unexported
+ 2023-05-11 cd39d2b internal/lsp/cache: support loading multiple orphaned files
+ 2023-05-11 abeba28 gopls/internal/regtest/marker: support proxy files in marker tests
+ 2023-05-11 18186f0 go/analysis/passes/slog: simplify function matching
+ 2023-05-11 9aa9d13 cmd/bisect, internal/bisect: use more precise skip suffixes, written in hex
+ 2023-05-11 3034d9c gopls/internal/lsp/cmd: append, don't overwrite, in PublishDiagnostics
+ 2023-05-10 4318d63 gopls: change the default value of "symbolScope" to "all"
+ 2023-05-10 f44f50e gopls/internal/lsp/source: implementation: report builtin 'error'
+ 2023-05-10 787e720 gopls/internal/lsp: optimize checks for ignored files
+ 2023-05-10 4ed7de1 gopls: add google-cloud-go as a benchmark repo
+ 2023-05-10 d799eba gopls: additional instrumentation during goimports
+ 2023-05-10 a7e7dc4 go/ssa: rename test cases in TestGenericBodies
+ 2023-05-10 d668f58 gopls/internal/regtest/marker: require cgo for issue59944.txt
+ 2023-05-10 005fa64 go/analysis/passes/slog: add check for slog.Group
+ 2023-05-09 033e628 go/ssa: more reindentation of TestGenericBodies
+ 2023-05-09 2310848 go/ssa: reindent test cases in TestGenericBodies
+ 2023-05-09 90e9c65 gopls/internal/lsp/cache: skip type errors after parse errors
+ 2023-05-09 08b24db gopls/internal/lsp/regtest: check for "// @marker" rogue space
+ 2023-05-09 b9c20f6 gopls/internal/regtest/marker: migrate @diag to new marker tests
+ 2023-05-09 4609d79 cmd/bisect: add -compile and -godebug shorthands
+ 2023-05-09 ddfa220 internal/fuzzy: improvements to the symbol scoring algorithm
+ 2023-05-09 3449242 go/types/objectpath: don't panic when receiver is missing a method
+ 2023-05-08 0809ec2 gopls/internal/lsp/source: document {All,Workspace}Metadata
+ 2023-05-08 8f7fb01 go/analysis/unitchecker: add test of go vet on std
+ 2023-05-08 23e52a3 bisect: diagnose bad targets better
+ 2023-05-08 d5af889 gopls: set GOWORK=off for loads from debug and safetoken tests
+ 2023-05-08 c93329a go/analysis/passes/printf: reshorten diagnostic about %s in Println call
+ 2023-05-08 6219726 go.mod: update golang.org/x dependencies
+ 2023-05-08 f4d143e go/ssa: cleanup TestGenericBodies to pickup package name
+ 2023-05-08 3d99ebe gopls/diff/unified: remove redundant information
+ 2023-05-05 479f5c6 go/ssa: Origin is only available after building
+ 2023-05-05 6d1dd12 go/analysis: simplify unusedresult
+ 2023-05-05 4a2dd0d go/callgraph/vta: allow pointer to type parameter in sliceArrayElem
+ 2023-05-05 7c6c2b7 go/ssa: keep syntax for instantiations
+ 2023-05-05 ce1b96b all: fix some comments
+ 2023-05-05 0500fd4 go/ssa: use core type in address
+ 2023-05-05 8e9b185 gopls/internal/lsp/source: add the "symbolScope" option
+ 2023-05-05 4ac71c0 internal/imports: sort fixes for deterministic results
+ 2023-05-05 573915d gopls/internal/lsp/cache: always init the resolver in runProcessEnvFunc
+ 2023-05-05 dd09381 bisect: move to internal/bisect until API is reviewed
+ 2023-05-05 516063a bisect, cmd/bisect: add new library and tool
+ 2023-05-05 58fedf6 internal/diffp: add patience diff from main repo
+ 2023-05-04 7b684a9 gopls: port import tests to the new marker framework
+ 2023-05-04 87974e3 gopls/internal/lsp/filecache: skip TestConcurrency on plan9 builder
+ 2023-05-04 c64bb76 gopls/internal/lsp/source: make infertypeargs a convenience analyzer
+ 2023-05-04 91b7a8e go/ssa: use origin method in source lookup
+ 2023-05-03 ba892bb go/types/internal/play: show formatted AST
+ 2023-05-03 7df6af8 gopls/internal/lsp/filecache: silently discard CRC errors on macOS
+ 2023-05-02 2563079 go/analysis/passes/printf: update directive diagnostic message
+ 2023-05-02 3f6c3b3 gopls: upgrade to latest version of LSP protocol
+ 2023-05-02 216928d gopls: port function extraction marker tests to the new framework
+ 2023-05-02 2415ce1 gopls: skip tests that load gopls packages if x/tools replacement is missing
+ 2023-05-02 17e5ef3 gopls/internal/lsp/cache: remove cycle check from buildMetadata
+ 2023-05-02 affb5fc gopls/internal/lsp/source: fix crash in definitions of builtins
+ 2023-05-02 558d701 gopls/internal/lsp/source: fix another bug in reference expansion
+ 2023-05-01 51dfad7 gopls: port workspace/symbol marker tests to the new framework
+ 2023-05-01 c6b5780 gopls: fix build at older Go versions
+ 2023-05-01 7590fe4 gopls/internal/lsp: hover over linkname directives.
+ 2023-05-01 ec61ad3 gopls/internal/lsp/source: add invert-if-condition refactoring
+ 2023-04-28 5283a01 go/packages: delete TestCgoOption as it doesn't test the cgo option
+ 2023-04-28 e2f3b25 gopls/internal/bug: record bug reports in file cache
+ 2023-04-28 ab24b7b gopls/internal/regtest/marker: add a test case for issue #59554
+ 2023-04-28 8235df3 gopls/internal/regtest/marker: port format tests to the new framework
+ 2023-04-28 80dc031 internal/diff: unified: match diff delete for empty file
+ 2023-04-27 165099b all: remove repeated definite articles
+ 2023-04-27 ac40903 internal/gocommand: simplify GoVersion invocation
+ 2023-04-27 9e0a7b1 copyright: don't require checkout to be named tools
+ 2023-04-26 94ed378 internal/lsp/testdata: update for new diagnostic from go list
+ 2023-04-26 a5c37ba gopls/internal/regtest/marker: skip on small machines
+ 2023-04-25 76e1037 internal/testenv: assume that mobile platforms are small machines
+ 2023-04-25 17e2d70 gopls/internal/bug: remove unused Data parameter
+ 2023-04-25 dd89a2e gopls/internal/lsp: remove now redundant debouncing logic
+ 2023-04-25 2a9398d go/analysis/passes/slog: do not report multiple incorrect keys
+ 2023-04-25 4baa3dc gopls/internal/bug: move bug package into gopls

Change-Id: I4cb08fe593bbc00102dbd266ad4ef1b6a1150e08
@gopherbot
Copy link

Change https://go.dev/cl/495262 mentions this issue: gopls: update go.mod for v0.12.0-pre.2

gopherbot pushed a commit to golang/tools that referenced this issue May 16, 2023
Remove the replace directive and update x/tools.

For golang/go#59818

Change-Id: I949598f4ccf9f708f5314f3d8f1faf05c0f55b9f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/495262
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
@findleyr findleyr self-assigned this May 22, 2023
@gopherbot
Copy link

Change https://go.dev/cl/497957 mentions this issue: all: merge master (9c97539) into gopls-release-branch.0.12

gopherbot pushed a commit to golang/tools that referenced this issue May 24, 2023
Also put back the x/tools replace directive in gopls/go.mod.

For golang/go#59818

Merge List:

+ 2023-05-24 9c97539 gopls/internal/lsp/cache: remove nested module warning
+ 2023-05-24 d44a094 gopls/internal/lsp/cmd: add a stats -anon flag to show anonymous data
+ 2023-05-24 e106694 gopls/internal/lsp: bundle certain quick-fixes with their diagnostic
+ 2023-05-24 5dc3f74 gopls/internal/lsp/filecache: reenable memory cache layer
+ 2023-05-24 7e146a6 gopls/internal/lsp/cmd: simplify connection type
+ 2023-05-24 1e60668 gopls/internal/regtest/workspace: unskip duplicate modules test
+ 2023-05-23 5ce721d gopls/doc: Fix broken links
+ 2023-05-23 7a03feb gopls/internal/lsp/cmd: remove vestiges of debugging golang/go#59475
+ 2023-05-22 a70f2bc gopls/internal/regtest/misc: update and unskip TestHoverIntLiteral
+ 2023-05-22 6997d19 gopls/internal/regtest/misc: unskip TestMajorOptionsChange
+ 2023-05-22 ec543c5 gopls/internal/lsp/cache: fix crash in Session.updateViewLocked
+ 2023-05-22 a12ee94 gopls/internal/regtest/misc: update some unilaterally skipped tests
+ 2023-05-22 5ff5cbb gopls: deprecate support for Go 1.16 and 1.17, update warnings
+ 2023-05-22 e6fd7f4 gopls/internal/lsp/cache: limit module scan to 100K files
+ 2023-05-22 9ca66ba gopls/internal/lsp/regtest: delete TestWatchReplaceTargets
+ 2023-05-22 edbfdbe gopls/internal/lsp/source/completion: (unimported) add placeholders
+ 2023-05-22 3a5dbf3 gopls: add a new "subdirWatchPatterns" setting
+ 2023-05-22 3c02551 internal/typesinternal: remove NewObjectpathFunc
+ 2023-05-20 0729362 present: reformat doc comment for lack of inline code
+ 2023-05-20 d4e66bd go/ssa: TestStdlib: disable check that function names are distinct
+ 2023-05-20 738ea2b go/ssa: use core type for field accesses
+ 2023-05-19 2ec4299 gopls/internal/lsp: split file-watching glob patterns
+ 2023-05-19 43b02ea gopls/internal/lsp/cache: only delete the most relevant mod tidy handle
+ 2023-05-19 5919673 internal/lsp/filecache: eliminate 'kind' directories
+ 2023-05-19 a5ef6c3 gopls/internal/lsp: keep track of overlays on the files map
+ 2023-05-19 d7f4359 gopls/internal/lsp/mod: optimizations for mod tidy diagnostics
+ 2023-05-19 2eb726b gopls/internal/lsp/filecache: touch only files older than 1h
+ 2023-05-19 b742cb9 gopls/internal/regtest/bench: add a benchmark for diagnosing saves
+ 2023-05-19 4d66324 gopls/internal/lsp/cache: tweak error message
+ 2023-05-19 e46df40 gopls/internal/lsp/filecache: delayed tweaks from code review
+ 2023-05-19 3df69b8 gopls/internal/lsp/debug: remove memory monitoring
+ 2023-05-19 a069704 gopls/internal/lsp/filecache: avoid flock
+ 2023-05-18 3d53c2d gopls/internal/lsp/cache: fix race in adhoc reloading
+ 2023-05-17 8b4b27b go/analysis/passes/slog: fix Group kv offset
+ 2023-05-17 242e5ed cover: eliminate an unnecessary fsync in TestParseProfiles
+ 2023-05-17 651d951 go/ssa: fix typo in package docs

Change-Id: Ie57d55ba8f3ae9bcf868db08088f68955b5e4856
@gopherbot
Copy link

Change https://go.dev/cl/497958 mentions this issue: gopls: update go.mod for v0.12.0-pre.3

gopherbot pushed a commit to golang/tools that referenced this issue May 24, 2023
Remove the replace directive and update x/tools.

For golang/go#59818

Change-Id: If008c641ce4ded03248db8850d70c2935f0919ba
Reviewed-on: https://go-review.googlesource.com/c/tools/+/497958
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@findleyr findleyr closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants