x/tools/gopls: strange results for references to unified.String #59805
Assignees
Labels
gopls/incremental
gopls
Issues related to the Go language server, gopls.
okay-after-beta1
Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1
release-blocker
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
findleyr
added
release-blocker
okay-after-beta1
gopherbot
added
Tools
findleyr
changed the title
|
Dup of #59674 (scope too large) in conjunction with #59851 (expansions repeatedly applied from concrete to interface types and back). I have verified that it was fixed by https://go.dev/cl/487017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reported by @pjweinb in chat: finding references to
x/tools/internal/diff.unified.Stringreturns several results that don't quite make sense. I would expect these to include references to(unified).Stringas well as any references to the interface methodfmt.Stringer.String, but I would not expect any references to theStringmethod of other concrete types.Since we haven't yet filtered to workspace packages (#59674), I see some strange results in std. For example, I see a reference to
(strings.Builder).Stringinside the(*expvar.Map).String)method. But surprisingly, I don't see a reference to the(*expvar.Map).String)method itself!Something is amiss.
The text was updated successfully, but these errors were encountered: