Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort: add unit tests for slice.go #59791

Closed
khareyash05 opened this issue Apr 24, 2023 · 8 comments
Closed

sort: add unit tests for slice.go #59791

khareyash05 opened this issue Apr 24, 2023 · 8 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Backlog

Comments

@khareyash05
Copy link

What version of Go are you using (go version)?

$ go version go1.19.2 windows/amd64

I would like to add tests for slice.go
@khareyash05 khareyash05 added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 24, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Apr 24, 2023
@dmitshur
Copy link
Contributor

CC @golang/vulndb.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. labels Apr 24, 2023
@timothy-king
Copy link
Contributor

What kind of tests are you hoping to add? Unit tests? Integration tests? Are these tests for the sort package? Are these tests of how x/vuln integrates with the sort package? What properties are you hoping to test?

@khareyash05
Copy link
Author

@timothy-king These are the unit tests for the functions in slice.go

@timothy-king timothy-king removed the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 25, 2023
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 25, 2023
@timothy-king timothy-king modified the milestones: vuln/unplanned, Backlog Apr 25, 2023
@timothy-king
Copy link
Contributor

I don't think this is related to vulncheck or vulndb then.

@khareyash05
Copy link
Author

I am sorry i labeled it wrong! @timothy-king Do we need these tests?

@timothy-king timothy-king changed the title x/vuln: add unit tests for slice.go sort: add unit tests for slice.go Apr 25, 2023
@timothy-king
Copy link
Contributor

It would probably depend on the tests. I am no sure what you intend on testing. There are tests of these functions in sort_test.go. Example https://cs.opensource.google/go/go/+/master:src/sort/sort_test.go;l=79 . If you have suggestions for tests that are not already covered, it could make sense.

@ianlancetaylor
Copy link
Contributor

There are also tests of sort.Slice in the file sort/example_test.go.

@seankhliao seankhliao added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed vulncheck or vulndb Issues for the x/vuln or x/vulndb repo labels Apr 25, 2023
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@timothy-king @dmitshur @ianlancetaylor @gopherbot @seankhliao @khareyash05