Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: trouble with Apache 2 LICENSE file at repository root #59782

Closed
tschaub opened this issue Apr 22, 2023 · 2 comments
Closed

x/pkgsite: trouble with Apache 2 LICENSE file at repository root #59782

tschaub opened this issue Apr 22, 2023 · 2 comments
Labels
FrozenDueToAge pkgsite/license Issues related to licenses on pkg.go.dev. See our license policy https://pkg.go.dev/license-policy pkgsite

Comments

@tschaub
Copy link

tschaub commented Apr 22, 2023

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/planetlabs/go-ogc@v0.8.0

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36

Screenshot

image

What did you do?

I visited https://pkg.go.dev/github.com/planetlabs/go-ogc.

What did you expect to see?

I expected to see the readme rendered and to be able to browse reference docs for the filter and api packages.

What did you see instead?

Instead, it looks the license information cannot be determined, so no additional information is shown.

Here is the license file for the v0.8.0 version referenced above: https://github.com/planetlabs/go-ogc/blob/v0.8.0/LICENSE

When I run go-licenses report github.com/planetlabs/go-ogc (in a project where this is a dependency), I see that it correctly detects the Apache 2 license.

Is there a way to run licensecheck in the same way that the pkg.go.dev site does so I can diagnose why the license is not getting identified?

@gopherbot gopherbot added this to the Unreleased milestone Apr 22, 2023
@seankhliao seankhliao added the pkgsite/license Issues related to licenses on pkg.go.dev. See our license policy https://pkg.go.dev/license-policy label Apr 24, 2023
@jamalc jamalc modified the milestones: Unreleased, pkgsite/later Apr 28, 2023
@jamalc
Copy link

jamalc commented Apr 28, 2023

Alterations to the text of the original license will cause your license to fall below our confidence threshold for detection. Can you revert the changes you have made?

s/LICENSE/NOTICE

Screenshot 2023-04-28 at 12 18 29 PM

@tschaub
Copy link
Author

tschaub commented Apr 28, 2023

Thank you for pointing this out, @jamalc. I have corrected the license text and the docs are rendering now.

@tschaub tschaub closed this as completed Apr 28, 2023
@golang golang locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge pkgsite/license Issues related to licenses on pkg.go.dev. See our license policy https://pkg.go.dev/license-policy pkgsite
Projects
None yet
Development

No branches or pull requests

4 participants