Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln/internal/vulncheck: TestCommand failures #59767

Open
gopherbot opened this issue Apr 21, 2023 · 25 comments
Open

x/vuln/internal/vulncheck: TestCommand failures #59767

gopherbot opened this issue Apr 21, 2023 · 25 comments
Assignees
@zpavlinovic
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/v0.2.0

Comments

@gopherbot
Copy link

gopherbot commented Apr 21, 2023 •
edited by bcmills 

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`

Issue created automatically to collect these failures.

Example (log):

main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.13s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo labels Apr 21, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck" && test == "TestCommand"
2023-04-21 19:00 android-386-emu vuln@b9d1eb91 go@130a7f8e x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.13s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-21 19:00 android-amd64-emu vuln@b9d1eb91 go@130a7f8e x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (1.27s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan

— watchflakes

@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Apr 21, 2023
@julieqiu julieqiu modified the milestones: vuln/unplanned, vuln/v0.2.0 Apr 21, 2023
@julieqiu julieqiu self-assigned this Apr 21, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck" && test == "TestCommand"
2023-04-21 19:00 android-amd64-emu vuln@b9d1eb91 go@ca9947db x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.12s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck" && test == "TestCommand"
2023-04-21 19:00 android-386-emu vuln@b9d1eb91 go@ca9947db x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.12s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-21 19:00 android-amd64-emu vuln@b9d1eb91 go@ca9947db x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.11s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck" && test == "TestCommand"
2023-04-21 19:00 android-386-emu vuln@b9d1eb91 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.10s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck" && test == "TestCommand"
2023-04-21 19:00 android-amd64-emu vuln@b9d1eb91 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.12s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:45 android-386-emu vuln@e340fa10 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.11s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:45 android-amd64-emu vuln@e340fa10 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.11s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:46 android-386-emu vuln@3db81ded go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.11s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:46 android-amd64-emu vuln@3db81ded go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.11s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:46 android-386-emu vuln@ba0df736 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.09s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:46 android-amd64-emu vuln@ba0df736 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.10s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:46 android-386-emu vuln@b43f5afc go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.11s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:46 android-amd64-emu vuln@b43f5afc go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.10s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck" && test == "TestCommand"
2023-04-24 18:45 android-386-emu vuln@56cdba20 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.10s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:45 android-amd64-emu vuln@56cdba20 go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.08s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
2023-04-24 18:46 android-amd64-emu vuln@b43f5afc go@c3c53a2c x/vuln/internal/vulncheck.TestCommand (log) 
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan
--- FAIL: TestCommand (0.11s)
    buildtest.go:78: exit status 1
main.go:13:2: no required module provides package golang.org/x/vuln/internal/scan; to add it:
	go get golang.org/x/vuln/internal/scan

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Apr 25, 2023

This is due to some wonkiness in how the android build environment copies over the source tree, which I'm hoping to resolve in CL 488655 by making the test environment less wonky.

@bcmills bcmills mentioned this issue Apr 26, 2023
Closed
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2023-03-07 01:03 freebsd-riscv64-unmatched vuln@c899e911 go@84609d87 x/vuln/cmd/govulncheck.TestCommand (log) 
vuln.go:6:2: github.com/tidwall/gjson@v1.9.2: Get "https://proxy.golang.org/github.com/tidwall/gjson/@v/v1.9.2.zip": Service Unavailable
vuln.go:7:2: golang.org/x/text@v0.3.0: Get "https://proxy.golang.org/golang.org/x/text/@v/v0.3.0.zip": Service Unavailable
--- FAIL: TestCommand (42.88s)
    buildtest.go:78: exit status 1
2023-03-23 18:53 freebsd-riscv64-unmatched vuln@0b459e67 go@3d5391ed x/vuln/cmd/govulncheck.TestCommand (log) 
vuln.go:6:2: github.com/tidwall/gjson@v1.9.2: Get "https://proxy.golang.org/github.com/tidwall/gjson/@v/v1.9.2.zip": Service Unavailable
--- FAIL: TestCommand (39.37s)
    buildtest.go:76: exit status 1
2023-03-30 14:18 linux-riscv64-unmatched vuln@701fad30 go@dead7887 x/vuln/cmd/govulncheck.TestCommand (log) 
vuln.go:6:2: github.com/tidwall/gjson@v1.9.2: Get "https://goproxy.cn/github.com/tidwall/gjson/@v/v1.9.2.zip": dial tcp: lookup goproxy.cn on 127.0.0.53:53: read udp 127.0.0.1:51633->127.0.0.53:53: i/o timeout
--- FAIL: TestCommand (61.62s)
    buildtest.go:76: exit status 1
2023-04-21 19:00 freebsd-riscv64-unmatched vuln@b9d1eb91 go@5a10d8a2 x/vuln/cmd/govulncheck.TestCommand (log) 
main.go:7:2: golang.org/x/text@v0.3.5: Get "https://proxy.golang.org/golang.org/x/text/@v/v0.3.5.zip": Service Unavailable
--- FAIL: TestCommand (52.17s)
    buildtest.go:78: exit status 1
2023-04-27 04:10 android-386-emu vuln@e55aa3a7 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (1.61s)
    buildtest.go:78: exit status 2
2023-04-27 04:10 android-amd64-emu vuln@e55aa3a7 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (0.56s)
    buildtest.go:78: exit status 2

— watchflakes

@bcmills bcmills mentioned this issue Apr 27, 2023
Closed
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2023-04-27 19:46 android-386-emu vuln@84fbccd9 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (1.74s)
    buildtest.go:78: exit status 2
2023-04-27 19:46 android-amd64-emu vuln@84fbccd9 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (0.49s)
    buildtest.go:78: exit status 2

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2023-04-27 21:15 android-amd64-emu vuln@da6deb85 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (0.52s)
    buildtest.go:78: exit status 2

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2023-04-27 21:15 android-386-emu vuln@da6deb85 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (1.96s)
    buildtest.go:78: exit status 2

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2023-04-27 21:17 android-386-emu vuln@fece1907 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (1.49s)
    buildtest.go:78: exit status 2
2023-04-27 21:17 android-amd64-emu vuln@fece1907 go@c3c53a2c TestCommand (log) 
--- FAIL: TestCommand (0.50s)
    buildtest.go:78: exit status 2

— watchflakes

@julieqiu julieqiu assigned ianthehat and unassigned julieqiu May 3, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2023-04-14 20:56 freebsd-riscv64-unmatched vuln@d3666e3e go@0853f8ca x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (81.46s)
    cmdtest.go:467: $ govulncheck -h
    cmdtest.go:467: $ govulncheck -mode=binary /tmp/workdir-host-freebsd-riscv64-unmatched/tmp/buildtest2882558175/strip
    cmdtest.go:467: $ govulncheck -mode=binary /tmp/workdir-host-freebsd-riscv64-unmatched/tmp/buildtest3683194429/vuln
    cmdtest.go:467: $ govulncheck -C /tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/modules/vuln -v .
    cmdtest.go:480: Govulncheck is a tool for finding known vulnerabilities.

        Usage:

        	govulncheck [flags] [patterns]
...
    --- FAIL: TestCommand/testdata/strip (0.10s)
        cmdtest.go:336: testdata/strip.ct:3: want=-, got=+
            $ govulncheck -mode=binary ${strip_binary} --> FAIL 3
              []string{
              	"govulncheck is an experimental tool. Share feedback at https://g"...,
              	"",
              	"Using govulncheck@v0.0.0-00000000000-20000101010101 with",
              	strings.Join({
              		"vulnerability data from testdata/vulndb",
            + 		"-v1",
...

          Standard library
            Found in: net/http@go1.18
            Fixed in: net/http@go1.19.1

            Call stacks in your code:
              #1: for function ListenAndServe
                golang.org/stdlib.main
                    .../stdlib.go:17:31
                net/http.ListenAndServe
2023-04-14 20:56 linux-riscv64-unmatched vuln@d3666e3e go@f8162a0e x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (51.86s)
    cmdtest.go:467: $ govulncheck -mode=binary /tmp/workdir-host-linux-riscv64-unmatched/tmp/buildtest225959449/vuln
    cmdtest.go:467: $ govulncheck -C /tmp/workdir-host-linux-riscv64-unmatched/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/modules/stdlib -v .
    cmdtest.go:467: $ govulncheck -mode=binary /tmp/workdir-host-linux-riscv64-unmatched/tmp/buildtest1259537293/strip
    cmdtest.go:467: $ govulncheck -C /tmp/workdir-host-linux-riscv64-unmatched/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/modules/nogomod .
    cmdtest.go:480: govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

        Using govulncheck@v0.0.0-00000000000-20000101010101 with
        vulnerability data from testdata/vulndb-v1 (last modified 01 Jan 21 00:00 UTC).

...
    --- FAIL: TestCommand/testdata/strip (0.03s)
        cmdtest.go:336: testdata/strip.ct:3: want=-, got=+
            $ govulncheck -mode=binary ${strip_binary} --> FAIL 3
              []string{
              	"govulncheck is an experimental tool. Share feedback at https://g"...,
              	"",
              	"Using govulncheck@v0.0.0-00000000000-20000101010101 with",
              	strings.Join({
              		"vulnerability data from testdata/vulndb",
            + 		"-v1",
...

          Standard library
            Found in: net/http@go1.18
            Fixed in: net/http@go1.19.1

            Call stacks in your code:
              #1: for function ListenAndServe
                golang.org/stdlib.main
                    .../stdlib.go:17:31
                net/http.ListenAndServe
2023-04-14 20:56 linux-riscv64-unmatched vuln@d3666e3e go@0853f8ca x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (81.39s)
    cmdtest.go:467: $ govulncheck -mode=binary /tmp/workdir-host-linux-riscv64-unmatched/tmp/buildtest1891071436/vuln
    cmdtest.go:467: $ govulncheck -C /tmp/workdir-host-linux-riscv64-unmatched/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/modules/vuln -v .
    cmdtest.go:467: $ govulncheck -h
    cmdtest.go:467: $ govulncheck -mode=binary /tmp/workdir-host-linux-riscv64-unmatched/tmp/buildtest3672020014/strip
    cmdtest.go:480: Govulncheck is a tool for finding known vulnerabilities.

        Usage:

        	govulncheck [flags] [patterns]
...
    --- FAIL: TestCommand/testdata/strip (0.11s)
        cmdtest.go:336: testdata/strip.ct:3: want=-, got=+
            $ govulncheck -mode=binary ${strip_binary} --> FAIL 3
              []string{
              	"govulncheck is an experimental tool. Share feedback at https://g"...,
              	"",
              	"Using govulncheck@v0.0.0-00000000000-20000101010101 with",
              	strings.Join({
              		"vulnerability data from testdata/vulndb",
            + 		"-v1",
...

          Standard library
            Found in: net/http@go1.18
            Fixed in: net/http@go1.19.1

            Call stacks in your code:
              #1: for function ListenAndServe
                golang.org/stdlib.main
                    .../stdlib.go:17:31
                net/http.ListenAndServe
2023-04-14 20:56 netbsd-arm-bsiegert vuln@d3666e3e go@0853f8ca x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (52.02s)
    cmdtest.go:467: $ govulncheck -mode=binary /var/gobuilder/buildlet/tmp/buildtest4096252026/vuln
    cmdtest.go:467: $ govulncheck -C /var/gobuilder/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/modules/stdlib -v .
    cmdtest.go:467: $ govulncheck -C /var/gobuilder/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/modules/nogomod .
    cmdtest.go:467: $ govulncheck -C /var/gobuilder/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/modules/vuln -v .
    cmdtest.go:480: govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

        Using govulncheck@v0.0.0-00000000000-20000101010101 with
        vulnerability data from testdata/vulndb-v1 (last modified 01 Jan 21 00:00 UTC).

...
    --- FAIL: TestCommand/testdata/strip (0.06s)
        cmdtest.go:336: testdata/strip.ct:3: want=-, got=+
            $ govulncheck -mode=binary ${strip_binary} --> FAIL 3
              []string{
              	"govulncheck is an experimental tool. Share feedback at https://g"...,
              	"",
              	"Using govulncheck@v0.0.0-00000000000-20000101010101 with",
              	strings.Join({
              		"vulnerability data from testdata/vulndb",
            + 		"-v1",
...

          Standard library
            Found in: net/http@go1.18
            Fixed in: net/http@go1.19.1

            Call stacks in your code:
              #1: for function ListenAndServe
                golang.org/stdlib.main
                    .../stdlib.go:17:31
                net/http.ListenAndServe
2023-05-15 16:23 freebsd-riscv64-unmatched vuln@c915f60f go@04e24728 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (84.47s)
    --- FAIL: TestCommand/testdata/sourcebadpattern (17.64s)
        cmdtest.go:336: testdata/sourcebadpattern.ct:1: want=-, got=+
            $ govulncheck -C ${moddir}/vuln blah --> FAIL 1
              []string{
              	... // 5 identical elements
              	"There are errors with the provided package patterns:",
              	"",
              	strings.Join({
              		"-: package ",
            - 		"foo is not in GOROOT (/tmp/foo",
            + 		"blah is not in std (/tmp/workdir-host-freebsd-riscv64-unmatched/",
            + 		"go/src/blah",
              		")",
              	}, ""),
              	"",
              	"For details on package patterns, see https://pkg.go.dev/cmd/go#h"...,
              }
2023-05-15 16:23 netbsd-arm-bsiegert vuln@c915f60f go@04e24728 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (60.19s)
    --- FAIL: TestCommand/testdata/sourcebadpattern (73.96s)
        cmdtest.go:336: testdata/sourcebadpattern.ct:1: want=-, got=+
            $ govulncheck -C ${moddir}/vuln blah --> FAIL 1
              []string{
              	... // 5 identical elements
              	"There are errors with the provided package patterns:",
              	"",
              	strings.Join({
              		"-: package ",
            - 		"foo is not in GOROOT (/tmp/foo",
            + 		"blah is not in std (/var/gobuilder/buildlet/go/src/blah",
              		")",
              	}, ""),
              	"",
              	"For details on package patterns, see https://pkg.go.dev/cmd/go#h"...,
              }
2023-05-15 16:23 netbsd-arm-bsiegert vuln@c915f60f go@7213f2e7 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (60.88s)
    --- FAIL: TestCommand/testdata/sourcebadpattern (42.18s)
        cmdtest.go:336: testdata/sourcebadpattern.ct:1: want=-, got=+
            $ govulncheck -C ${moddir}/vuln blah --> FAIL 1
              []string{
              	... // 5 identical elements
              	"There are errors with the provided package patterns:",
              	"",
              	strings.Join({
              		"-: package ",
            - 		"foo is not in GOROOT (/tmp/foo",
            + 		"blah is not in std (/var/gobuilder/buildlet/go/src/blah",
              		")",
              	}, ""),
              	"",
              	"For details on package patterns, see https://pkg.go.dev/cmd/go#h"...,
              }
2023-05-15 16:23 netbsd-arm-bsiegert vuln@c915f60f go@ff3aefba x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (58.62s)
    --- FAIL: TestCommand/testdata/sourcebadpattern (30.96s)
        cmdtest.go:336: testdata/sourcebadpattern.ct:1: want=-, got=+
            $ govulncheck -C ${moddir}/vuln blah --> FAIL 1
              []string{
              	... // 5 identical elements
              	"There are errors with the provided package patterns:",
              	"",
              	strings.Join({
              		"-: package ",
            - 		"foo is not in GOROOT (/tmp/foo",
            + 		"blah is not in std (/var/gobuilder/buildlet/go/src/blah",
              		")",
              	}, ""),
              	"",
              	"For details on package patterns, see https://pkg.go.dev/cmd/go#h"...,
              }

— watchflakes

@gopherbot gopherbot reopened this Jan 26, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-01-18 21:35 x_vuln-go1.22-windows-amd64-longtest vuln@4b54a8b0 release-branch.go1.22@66f8e1e8 x/vuln/cmd/govulncheck.TestCommand (log) 
=== RUN   TestCommand
go: downloading github.com/tidwall/gjson v1.9.2
go: downloading github.com/tidwall/match v1.1.0
go: downloading github.com/tidwall/pretty v1.2.0
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
    buildtest.go:78: exit status 1
--- FAIL: TestCommand (0.92s)

— watchflakes

@zpavlinovic zpavlinovic assigned zpavlinovic and unassigned ianthehat Feb 1, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/560376 mentions this issue: internal/test: add more info on GoBuild failures

gopherbot pushed a commit to golang/vuln that referenced this issue Feb 5, 2024
@zpavlinovic
internal/test: add more info on GoBuild failures
fadf1fa 
Updates golang/go#59767

Change-Id: I314db4e5837031210fe7b52630898b88d044b7a6
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/560376
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Maceo Thompson <maceothompson@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-02-06 16:18 darwin-amd64-longtest vuln@0b50c252 go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (38.91s)
    --- FAIL: TestCommand//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (49.74s)
        cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:18 linux-386-longtest vuln@0b50c252 go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (7.52s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (15.53s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:18 linux-amd64-longtest vuln@0b50c252 go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (6.25s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (13.21s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:18 linux-amd64-longtest-race vuln@0b50c252 go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (12.94s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (28.87s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:18 linux-arm64-longtest vuln@0b50c252 go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (4.04s)
    --- FAIL: TestCommand//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (7.98s)
        cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:18 windows-amd64-longtest vuln@0b50c252 go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (10.33s)
    --- FAIL: TestCommand/C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\testfiles\source-call\source_stdlib_text (14.95s)
        cmdtest.go:336: C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\testfiles\source-call\source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:30 darwin-amd64-longtest vuln@c154f6ab go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (31.61s)
    --- FAIL: TestCommand//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (41.21s)
        cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:30 linux-386-longtest vuln@c154f6ab go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (7.49s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (10.81s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:30 linux-amd64-longtest vuln@c154f6ab go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (4.17s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (9.95s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:30 linux-amd64-longtest-race vuln@c154f6ab go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (19.41s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (51.82s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:30 linux-arm64-longtest vuln@c154f6ab go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (4.05s)
    --- FAIL: TestCommand//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text (6.34s)
        cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }
2024-02-06 16:30 windows-amd64-longtest vuln@c154f6ab go@4b0e0863 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (8.03s)
    --- FAIL: TestCommand/C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\testfiles\source-call\source_stdlib_text (11.72s)
        cmdtest.go:336: C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\testfiles\source-call\source_stdlib_text.ct:26: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -show=traces . --> FAIL 3
              []string{
              	... // 13 identical elements
              	"      #1: for function net/http.ListenAndServe",
              	"        .../stdlib.go:17:31: golang.org/stdlib.main",
              	strings.Join({
              		"        .../server.go:343",
            - 		"9",
            + 		"6",
              		":6: net/http.ListenAndServe",
              	}, ""),
              	"",
              	"Your code is affected by 1 vulnerability from the Go standard li"...,
              	... // 3 identical elements
              }

— watchflakes

@zpavlinovic
Copy link
Contributor

Should be addressed by https://go-review.git.corp.google.com/c/vuln/+/562215

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-02-13 17:00 linux-386-longtest vuln@26c8e26c go@e17e5308 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (5.35s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json (6.49s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/replace -json ./...
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
...
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json (8.62s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -json .
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
            - 	`        "package": "net/http"`,
              	"      }",
              	"    ]",
              	... // 46 identical elements
              }
2024-02-13 17:00 linux-amd64-longtest vuln@26c8e26c go@e17e5308 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (4.66s)
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json (4.39s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/replace -json ./...
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
...
    --- FAIL: TestCommand//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json (6.72s)
        cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -json .
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
            - 	`        "package": "net/http"`,
              	"      }",
              	"    ]",
              	... // 46 identical elements
              }
2024-02-13 17:00 linux-arm64-longtest vuln@26c8e26c go@e17e5308 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (3.97s)
    --- FAIL: TestCommand//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json (3.84s)
        cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/replace -json ./...
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
...
    --- FAIL: TestCommand//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json (5.26s)
        cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -json .
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
            - 	`        "package": "net/http"`,
              	"      }",
              	"    ]",
              	... // 46 identical elements
              }

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-02-13 17:00 darwin-amd64-longtest vuln@26c8e26c go@e17e5308 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (40.56s)
    --- FAIL: TestCommand//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json (16.96s)
        cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_stdlib_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/stdlib -json .
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
...
    --- FAIL: TestCommand//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json (17.05s)
        cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/testfiles/source-call/source_replace_json.ct:3: want=-, got=+
            $ govulncheck -C ${moddir}/replace -json ./...
              []string{
              	... // 132 identical elements
              	"      {",
              	`        "module": "stdlib",`,
            - 	`        "version": "v1.18.0",`,
            + 	`        "version": "v1.18.0"`,
            - 	`        "package": "net/http"`,
              	"      }",
              	"    ]",
              	... // 212 identical elements
              }

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-02-13 18:56 x_vuln-go1.21-linux-amd64-longtest-race vuln@06a69c43 release-branch.go1.21@b214108e x/vuln/cmd/govulncheck.TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1883840934/cmd/govulncheck/testdata/testfiles/stdlib/query_vstdlib_json (log) 
=== RUN   TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1883840934/cmd/govulncheck/testdata/testfiles/stdlib/query_vstdlib_json
=== PAUSE TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1883840934/cmd/govulncheck/testdata/testfiles/stdlib/query_vstdlib_json
=== CONT  TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1883840934/cmd/govulncheck/testdata/testfiles/stdlib/query_vstdlib_json
==================
WARNING: DATA RACE
Write at 0x00000125fcb0 by goroutine 47:
  golang.org/x/vuln/internal/vulncheck.NewPackageGraph()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1883840934/internal/vulncheck/packages.go:37 +0x2b9
  golang.org/x/vuln/internal/scan.runSource()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1883840934/internal/scan/source.go:34 +0x1d9
...
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:345 +0x54
  github.com/google/go-cmdtest.(*TestSuite).compare.func1()
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:335 +0x6e
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1595 +0x261
  testing.(*T).Run.func1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1648 +0x44
==================
    testing.go:1465: race detected during execution of test
--- FAIL: TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1883840934/cmd/govulncheck/testdata/testfiles/stdlib/query_vstdlib_json (7.23s)
2024-02-13 18:56 x_vuln-go1.21-windows-amd64-longtest vuln@06a69c43 release-branch.go1.21@b214108e x/vuln/cmd/govulncheck.TestCommand/C:\b\s\w\ir\x\w\targetrepo360751123\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (log) 
=== RUN   TestCommand/C:\b\s\w\ir\x\w\targetrepo360751123\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== PAUSE TestCommand/C:\b\s\w\ir\x\w\targetrepo360751123\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== CONT  TestCommand/C:\b\s\w\ir\x\w\targetrepo360751123\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
    cmdtest.go:336: C:\b\s\w\ir\x\w\targetrepo360751123\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text.ct:3: want=-, got=+
        $ govulncheck -C ${moddir}/vuln/subdir . --> FAIL 3
          []string{
          	... // 12 identical elements
          	"    Fixed in: golang.org/x/text@v0.3.7",
          	"    Example traces found:",
          	strings.Join({
...
        + 		`\`,
          		"parse.go:<l>:<c>: golang.org/x/text/language.Parse",
          	}, ""),
          	"",
          	"Your code is affected by 1 vulnerability from 1 module.",
          	... // 4 identical elements
          }
        
        
--- FAIL: TestCommand/C:\b\s\w\ir\x\w\targetrepo360751123\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (10.81s)
2024-02-13 18:56 x_vuln-go1.22-linux-amd64-longtest-race vuln@06a69c43 release-branch.go1.22@20107e05 x/vuln/cmd/govulncheck.TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1769350119/cmd/govulncheck/testdata/testfiles/failures/binary_fail (log) 
=== RUN   TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1769350119/cmd/govulncheck/testdata/testfiles/failures/binary_fail
=== PAUSE TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1769350119/cmd/govulncheck/testdata/testfiles/failures/binary_fail
=== CONT  TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1769350119/cmd/govulncheck/testdata/testfiles/failures/binary_fail
==================
WARNING: DATA RACE
Write at 0x0000012c6b00 by goroutine 47:
  golang.org/x/vuln/internal/vulncheck.NewPackageGraph()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1769350119/internal/vulncheck/packages.go:37 +0x2c7
  golang.org/x/vuln/internal/scan.runSource()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1769350119/internal/scan/source.go:34 +0x1f0
...
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:345 +0x5a
  github.com/google/go-cmdtest.(*TestSuite).compare.func1()
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:335 +0x6e
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x44
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1769350119/cmd/govulncheck/testdata/testfiles/failures/binary_fail (44.82s)
2024-02-13 18:56 x_vuln-go1.22-windows-amd64-longtest vuln@06a69c43 release-branch.go1.22@20107e05 x/vuln/cmd/govulncheck.TestCommand/C:\b\s\w\ir\x\w\targetrepo2194065080\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (log) 
=== RUN   TestCommand/C:\b\s\w\ir\x\w\targetrepo2194065080\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== PAUSE TestCommand/C:\b\s\w\ir\x\w\targetrepo2194065080\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== CONT  TestCommand/C:\b\s\w\ir\x\w\targetrepo2194065080\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
    cmdtest.go:336: C:\b\s\w\ir\x\w\targetrepo2194065080\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text.ct:3: want=-, got=+
        $ govulncheck -C ${moddir}/vuln/subdir . --> FAIL 3
          []string{
          	... // 12 identical elements
          	"    Fixed in: golang.org/x/text@v0.3.7",
          	"    Example traces found:",
          	strings.Join({
...
        + 		`\`,
          		"parse.go:<l>:<c>: golang.org/x/text/language.Parse",
          	}, ""),
          	"",
          	"Your code is affected by 1 vulnerability from 1 module.",
          	... // 4 identical elements
          }
        
        
--- FAIL: TestCommand/C:\b\s\w\ir\x\w\targetrepo2194065080\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (10.51s)
2024-02-13 18:56 x_vuln-gotip-windows-amd64-longtest vuln@06a69c43 go@62cebb2e x/vuln/cmd/govulncheck.TestCommand/C:\b\s\w\ir\x\w\targetrepo2005988129\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (log) 
=== RUN   TestCommand/C:\b\s\w\ir\x\w\targetrepo2005988129\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== PAUSE TestCommand/C:\b\s\w\ir\x\w\targetrepo2005988129\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== CONT  TestCommand/C:\b\s\w\ir\x\w\targetrepo2005988129\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
    cmdtest.go:336: C:\b\s\w\ir\x\w\targetrepo2005988129\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text.ct:3: want=-, got=+
        $ govulncheck -C ${moddir}/vuln/subdir . --> FAIL 3
          []string{
          	... // 12 identical elements
          	"    Fixed in: golang.org/x/text@v0.3.7",
          	"    Example traces found:",
          	strings.Join({
...
        + 		`\`,
          		"parse.go:<l>:<c>: golang.org/x/text/language.Parse",
          	}, ""),
          	"",
          	"Your code is affected by 1 vulnerability from 1 module.",
          	... // 4 identical elements
          }
        
        
--- FAIL: TestCommand/C:\b\s\w\ir\x\w\targetrepo2005988129\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (8.52s)
2024-02-13 19:29 x_vuln-go1.21-linux-amd64-longtest-race vuln@08ad966e release-branch.go1.21@b214108e x/vuln/cmd/govulncheck.TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3625638365/cmd/govulncheck/testdata/testfiles/source-call/source_replace_text (log) 
=== RUN   TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3625638365/cmd/govulncheck/testdata/testfiles/source-call/source_replace_text
=== PAUSE TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3625638365/cmd/govulncheck/testdata/testfiles/source-call/source_replace_text
=== CONT  TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3625638365/cmd/govulncheck/testdata/testfiles/source-call/source_replace_text
==================
WARNING: DATA RACE
Write at 0x00000125fcb0 by goroutine 51:
  golang.org/x/vuln/internal/vulncheck.NewPackageGraph()
      /home/swarming/.swarming/w/ir/x/w/targetrepo3625638365/internal/vulncheck/packages.go:37 +0x2b9
  golang.org/x/vuln/internal/scan.runSource()
      /home/swarming/.swarming/w/ir/x/w/targetrepo3625638365/internal/scan/source.go:34 +0x1d9
...
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:345 +0x54
  github.com/google/go-cmdtest.(*TestSuite).compare.func1()
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:335 +0x6e
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1595 +0x261
  testing.(*T).Run.func1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1648 +0x44
==================
    testing.go:1465: race detected during execution of test
--- FAIL: TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3625638365/cmd/govulncheck/testdata/testfiles/source-call/source_replace_text (22.48s)
2024-02-13 19:29 x_vuln-go1.21-windows-amd64-longtest vuln@08ad966e release-branch.go1.21@b214108e x/vuln/cmd/govulncheck.TestCommand/C:\b\s\w\ir\x\w\targetrepo3636949741\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (log) 
=== RUN   TestCommand/C:\b\s\w\ir\x\w\targetrepo3636949741\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== PAUSE TestCommand/C:\b\s\w\ir\x\w\targetrepo3636949741\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== CONT  TestCommand/C:\b\s\w\ir\x\w\targetrepo3636949741\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
    cmdtest.go:336: C:\b\s\w\ir\x\w\targetrepo3636949741\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text.ct:3: want=-, got=+
        $ govulncheck -C ${moddir}/vuln/subdir . --> FAIL 3
          []string{
          	... // 12 identical elements
          	"    Fixed in: golang.org/x/text@v0.3.7",
          	"    Example traces found:",
          	strings.Join({
...
        + 		`\`,
          		"parse.go:<l>:<c>: golang.org/x/text/language.Parse",
          	}, ""),
          	"",
          	"Your code is affected by 1 vulnerability from 1 module.",
          	... // 4 identical elements
          }
        
        
--- FAIL: TestCommand/C:\b\s\w\ir\x\w\targetrepo3636949741\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (11.22s)
2024-02-13 19:29 x_vuln-go1.22-linux-amd64-longtest-race vuln@08ad966e release-branch.go1.22@20107e05 x/vuln/cmd/govulncheck.TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo2432006890/cmd/govulncheck/testdata/testfiles/failures/source_fail (log) 
=== RUN   TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo2432006890/cmd/govulncheck/testdata/testfiles/failures/source_fail
=== PAUSE TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo2432006890/cmd/govulncheck/testdata/testfiles/failures/source_fail
=== CONT  TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo2432006890/cmd/govulncheck/testdata/testfiles/failures/source_fail
==================
WARNING: DATA RACE
Write at 0x0000012c6b00 by goroutine 66:
  golang.org/x/vuln/internal/vulncheck.NewPackageGraph()
      /home/swarming/.swarming/w/ir/x/w/targetrepo2432006890/internal/vulncheck/packages.go:37 +0x2c7
  golang.org/x/vuln/internal/scan.runSource()
      /home/swarming/.swarming/w/ir/x/w/targetrepo2432006890/internal/scan/source.go:34 +0x1f0
...
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:345 +0x5a
  github.com/google/go-cmdtest.(*TestSuite).compare.func1()
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:335 +0x6e
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x44
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo2432006890/cmd/govulncheck/testdata/testfiles/failures/source_fail (45.52s)
2024-02-13 19:29 x_vuln-go1.22-windows-amd64-longtest vuln@08ad966e release-branch.go1.22@20107e05 x/vuln/cmd/govulncheck.TestCommand/C:\b\s\w\ir\x\w\targetrepo2950037084\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (log) 
=== RUN   TestCommand/C:\b\s\w\ir\x\w\targetrepo2950037084\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== PAUSE TestCommand/C:\b\s\w\ir\x\w\targetrepo2950037084\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== CONT  TestCommand/C:\b\s\w\ir\x\w\targetrepo2950037084\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
    cmdtest.go:336: C:\b\s\w\ir\x\w\targetrepo2950037084\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text.ct:3: want=-, got=+
        $ govulncheck -C ${moddir}/vuln/subdir . --> FAIL 3
          []string{
          	... // 12 identical elements
          	"    Fixed in: golang.org/x/text@v0.3.7",
          	"    Example traces found:",
          	strings.Join({
...
        + 		`\`,
          		"parse.go:<l>:<c>: golang.org/x/text/language.Parse",
          	}, ""),
          	"",
          	"Your code is affected by 1 vulnerability from 1 module.",
          	... // 4 identical elements
          }
        
        
--- FAIL: TestCommand/C:\b\s\w\ir\x\w\targetrepo2950037084\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (10.77s)
2024-02-13 19:29 x_vuln-gotip-linux-amd64-longtest-race vuln@08ad966e go@48d899dc x/vuln/cmd/govulncheck.TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1093573570/cmd/govulncheck/testdata/testfiles/source-call/source_call_json (log) 
=== RUN   TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1093573570/cmd/govulncheck/testdata/testfiles/source-call/source_call_json
=== PAUSE TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1093573570/cmd/govulncheck/testdata/testfiles/source-call/source_call_json
=== CONT  TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1093573570/cmd/govulncheck/testdata/testfiles/source-call/source_call_json
==================
WARNING: DATA RACE
Write at 0x0000012c8b40 by goroutine 48:
  golang.org/x/vuln/internal/vulncheck.NewPackageGraph()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1093573570/internal/vulncheck/packages.go:37 +0x2c7
  golang.org/x/vuln/internal/scan.runSource()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1093573570/internal/scan/source.go:34 +0x1f0
...
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:345 +0x5a
  github.com/google/go-cmdtest.(*TestSuite).compare.func1()
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:335 +0x6e
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x44
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1093573570/cmd/govulncheck/testdata/testfiles/source-call/source_call_json (32.25s)
2024-02-13 19:29 x_vuln-gotip-windows-amd64-longtest vuln@08ad966e go@48d899dc x/vuln/cmd/govulncheck.TestCommand/C:\b\s\w\ir\x\w\targetrepo2139445425\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (log) 
=== RUN   TestCommand/C:\b\s\w\ir\x\w\targetrepo2139445425\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== PAUSE TestCommand/C:\b\s\w\ir\x\w\targetrepo2139445425\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
=== CONT  TestCommand/C:\b\s\w\ir\x\w\targetrepo2139445425\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text
    cmdtest.go:336: C:\b\s\w\ir\x\w\targetrepo2139445425\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text.ct:3: want=-, got=+
        $ govulncheck -C ${moddir}/vuln/subdir . --> FAIL 3
          []string{
          	... // 12 identical elements
          	"    Fixed in: golang.org/x/text@v0.3.7",
          	"    Example traces found:",
          	strings.Join({
...
        + 		`\`,
          		"parse.go:<l>:<c>: golang.org/x/text/language.Parse",
          	}, ""),
          	"",
          	"Your code is affected by 1 vulnerability from 1 module.",
          	... // 4 identical elements
          }
        
        
--- FAIL: TestCommand/C:\b\s\w\ir\x\w\targetrepo2139445425\cmd\govulncheck\testdata\testfiles\source-call\source_subdir_text (15.31s)
2024-02-15 14:28 x_vuln-go1.21-linux-amd64-longtest-race vuln@2dec2336 release-branch.go1.21@b214108e x/vuln/cmd/govulncheck.TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1212492230/cmd/govulncheck/testdata/testfiles/stdlib/query_stdlib_json (log) 
=== RUN   TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1212492230/cmd/govulncheck/testdata/testfiles/stdlib/query_stdlib_json
=== PAUSE TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1212492230/cmd/govulncheck/testdata/testfiles/stdlib/query_stdlib_json
=== CONT  TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1212492230/cmd/govulncheck/testdata/testfiles/stdlib/query_stdlib_json
==================
WARNING: DATA RACE
Write at 0x00000125fcb0 by goroutine 47:
  golang.org/x/vuln/internal/vulncheck.NewPackageGraph()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1212492230/internal/vulncheck/packages.go:37 +0x2b9
  golang.org/x/vuln/internal/scan.runSource()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1212492230/internal/scan/source.go:34 +0x1d9
...
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:345 +0x54
  github.com/google/go-cmdtest.(*TestSuite).compare.func1()
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:335 +0x6e
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1595 +0x261
  testing.(*T).Run.func1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1648 +0x44
==================
    testing.go:1465: race detected during execution of test
--- FAIL: TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo1212492230/cmd/govulncheck/testdata/testfiles/stdlib/query_stdlib_json (14.31s)
2024-02-15 14:28 x_vuln-gotip-linux-amd64-longtest-race vuln@2dec2336 go@b6ca5861 x/vuln/cmd/govulncheck.TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3564838747/cmd/govulncheck/testdata/testfiles/usage/usage (log) 
=== RUN   TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3564838747/cmd/govulncheck/testdata/testfiles/usage/usage
=== PAUSE TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3564838747/cmd/govulncheck/testdata/testfiles/usage/usage
=== CONT  TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3564838747/cmd/govulncheck/testdata/testfiles/usage/usage
==================
WARNING: DATA RACE
Write at 0x0000012c8b40 by goroutine 48:
  golang.org/x/vuln/internal/vulncheck.NewPackageGraph()
      /home/swarming/.swarming/w/ir/x/w/targetrepo3564838747/internal/vulncheck/packages.go:37 +0x2c7
  golang.org/x/vuln/internal/scan.runSource()
      /home/swarming/.swarming/w/ir/x/w/targetrepo3564838747/internal/scan/source.go:34 +0x1f0
...
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:345 +0x5a
  github.com/google/go-cmdtest.(*TestSuite).compare.func1()
      /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/github.com/google/go-cmdtest@v0.4.1-0.20220921163831-55ab3332a786/cmdtest.go:335 +0x6e
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x44
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestCommand//home/swarming/.swarming/w/ir/x/w/targetrepo3564838747/cmd/govulncheck/testdata/testfiles/usage/usage (44.36s)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-03-25 18:40 darwin-amd64-longtest vuln@6f169c6e go@1f354a60 x/vuln/cmd/govulncheck.TestCommand (log) 
vuln.go:7:2: github.com/tidwall/gjson@v1.6.5: Get "https://proxy.golang.org/github.com/tidwall/gjson/@v/v1.6.5.zip": dial tcp 142.250.191.177:443: connect: operation timed out
--- FAIL: TestCommand (29.95s)
    buildtest.go:82: /tmp/buildlet/go/bin/go build -o /tmp/buildlet/tmp/buildtest5622601/vuln: exit status 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-03-28 19:32 linux-386-longtest vuln@84e19065 go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (37.97s)
    --- FAIL: TestCommand/common (7.02s)
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif (2.36s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
...
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (5.55s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                  	"          }",
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
...
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "error",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib). Run the call-level analysis to understand whether your code actually calls the vulnerabilities."`,
                - 	"          }",
                  	"        }",
                  	"      ]",
                  	... // 3 identical elements
                  }
2024-03-28 19:32 linux-amd64-longtest vuln@84e19065 go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (27.88s)
    --- FAIL: TestCommand/common (5.75s)
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (3.96s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                  	"          }",
                - 	"        },",
...
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif (4.18s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan module -C ${moddir}/vuln
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code depends on 1 vulnerable module (g`...,
                  	"          }",
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
...
                - 	"              },",
                - 	`              "helpUri": "https://pkg.go.dev/vuln/GO-2022-0969",`,
                - 	`              "properties": {`,
                - 	`                "tags": [`,
                - 	`                  "CVE-2022-27664",`,
                - 	`                  "GHSA-69cg-p879-7622"`,
                - 	"                ]",
                - 	"              }",
                  	... // 164 identical and 7 removed elements
                  }
2024-03-28 19:32 linux-amd64-longtest-race vuln@84e19065 go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (96.25s)
    --- FAIL: TestCommand/common (11.12s)
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif (16.38s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan module -C ${moddir}/vuln
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code depends on 1 vulnerable module (g`...,
                  	"          }",
                - 	"        },",
...
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif (15.94s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
                - 	"            {",
                - 	`              "id": "GO-2022-0969",`,
...
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "warning",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib), but doesn't appear to import any of the vulnerable symbols."`,
                - 	"          }",
                  	"        }",
                  	"      ]",
                  	... // 3 identical elements
                  }
2024-03-28 19:32 linux-arm64-longtest vuln@84e19065 go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (19.58s)
    --- FAIL: TestCommand/common (3.62s)
        --- FAIL: TestCommand/common//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif (0.83s)
            cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan module -C ${moddir}/vuln
                  []string{
                  	... // 127 identical elements
                  	`          "message": {`,
                  	`            "text": "Your code depends on 1 vulnerable module (g`...,
                - 	"          }",
...
        --- FAIL: TestCommand/common//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (2.99s)
            cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 127 identical elements
                  	`          "message": {`,
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                - 	"          }",
                - 	"        },",
                - 	"        {",
...
                - 	"              },",
                - 	`              "helpUri": "https://pkg.go.dev/vuln/GO-2022-0969",`,
                - 	`              "properties": {`,
                - 	`                "tags": [`,
                - 	`                  "CVE-2022-27664",`,
                - 	`                  "GHSA-69cg-p879-7622"`,
                - 	"                ]",
                - 	"              }",
                  	... // 164 identical and 7 removed elements
                  }
2024-03-28 19:32 windows-amd64-longtest vuln@84e19065 go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (24.29s)
    --- FAIL: TestCommand/common (5.83s)
        --- FAIL: TestCommand/common/C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-call\source_call_sarif (4.47s)
            cmdtest.go:336: C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-call\source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
...
        --- FAIL: TestCommand/common/C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-package\source_package_sarif (2.85s)
            cmdtest.go:336: C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-package\source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                  	"          }",
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
...
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "error",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib). Run the call-level analysis to understand whether your code actually calls the vulnerabilities."`,
                - 	"          }",
                  	"        }",
                  	"      ]",
                  	... // 3 identical elements
                  }
2024-03-28 19:32 linux-386-longtest vuln@df69562c go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (36.65s)
    --- FAIL: TestCommand/common (6.63s)
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif (2.25s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
...
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (7.13s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 127 identical elements
                  	`          "message": {`,
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                - 	"          }",
                - 	"        },",
                - 	"        {",
...
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "error",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib). Run the call-level analysis to understand whether your code actually calls the vulnerabilities."`,
                  	"          }",
                  	"        }",
                  	... // 4 identical elements
                  }
2024-03-28 19:32 linux-amd64-longtest vuln@df69562c go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (31.18s)
    --- FAIL: TestCommand/common (6.67s)
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif (4.61s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
...
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (2.95s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 127 identical elements
                  	`          "message": {`,
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                - 	"          }",
                - 	"        },",
                - 	"        {",
...
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "error",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib). Run the call-level analysis to understand whether your code actually calls the vulnerabilities."`,
                  	"          }",
                  	"        }",
                  	... // 4 identical elements
                  }
2024-03-28 19:32 linux-amd64-longtest-race vuln@df69562c go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (102.07s)
    --- FAIL: TestCommand/common (12.01s)
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif (14.67s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
...
        --- FAIL: TestCommand/common//workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (19.07s)
            cmdtest.go:336: /workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                  	"          }",
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
...
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "error",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib). Run the call-level analysis to understand whether your code actually calls the vulnerabilities."`,
                - 	"          }",
                  	"        }",
                  	"      ]",
                  	... // 3 identical elements
                  }
2024-03-28 19:32 linux-arm64-longtest vuln@df69562c go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (18.86s)
    --- FAIL: TestCommand/common (3.55s)
        --- FAIL: TestCommand/common//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif (4.62s)
            cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
...
        --- FAIL: TestCommand/common//tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif (1.01s)
            cmdtest.go:336: /tmp/workdir/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan module -C ${moddir}/vuln
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code depends on 1 vulnerable module (g`...,
                  	"          }",
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
...
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "warning",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib), but doesn't appear to import any of the vulnerable symbols."`,
                - 	"          }",
                  	"        }",
                  	"      ]",
                  	... // 3 identical elements
                  }
2024-03-28 19:32 windows-amd64-longtest vuln@df69562c go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (36.23s)
    --- FAIL: TestCommand/common (8.20s)
        --- FAIL: TestCommand/common/C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-package\source_package_sarif (6.09s)
            cmdtest.go:336: C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-package\source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                  	"          }",
                - 	"        },",
...
        --- FAIL: TestCommand/common/C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-module\source_module_sarif (7.37s)
            cmdtest.go:336: C:\workdir\gopath\src\golang.org\x\vuln\cmd\govulncheck\testdata\common\testfiles\source-module\source_module_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan module -C ${moddir}/vuln
                  []string{
                  	... // 128 identical elements
                  	`            "text": "Your code depends on 1 vulnerable module (g`...,
                  	"          }",
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
...
                - 	"              },",
                - 	`              "helpUri": "https://pkg.go.dev/vuln/GO-2022-0969",`,
                - 	`              "properties": {`,
                - 	`                "tags": [`,
                - 	`                  "CVE-2022-27664",`,
                - 	`                  "GHSA-69cg-p879-7622"`,
                - 	"                ]",
                - 	"              }",
                  	... // 164 identical and 7 removed elements
                  }

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-03-28 19:32 darwin-amd64-longtest vuln@84e19065 go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (113.77s)
    --- FAIL: TestCommand/common (22.82s)
        --- FAIL: TestCommand/common//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (8.28s)
            cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 127 identical elements
                  	`          "message": {`,
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                - 	"          }",
...
        --- FAIL: TestCommand/common//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif (8.52s)
            cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-module/source_module_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan module -C ${moddir}/vuln
                  []string{
                  	... // 127 identical elements
                  	`          "message": {`,
                  	`            "text": "Your code depends on 1 vulnerable module (g`...,
                - 	"          }",
                - 	"        },",
                - 	"        {",
...
                - 	"              },",
                - 	`              "helpUri": "https://pkg.go.dev/vuln/GO-2022-0969",`,
                - 	`              "properties": {`,
                - 	`                "tags": [`,
                - 	`                  "CVE-2022-27664",`,
                - 	`                  "GHSA-69cg-p879-7622"`,
                - 	"                ]",
                - 	"              }",
                  	... // 164 identical and 7 removed elements
                  }
2024-03-28 19:32 darwin-amd64-longtest vuln@df69562c go@33fd95b8 x/vuln/cmd/govulncheck.TestCommand (log) 
--- FAIL: TestCommand (119.73s)
    --- FAIL: TestCommand/common (23.33s)
        --- FAIL: TestCommand/common//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif (5.49s)
            cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct:3: want=-, got=+
                $ govulncheck -C ${moddir}/vuln -format sarif ./...
                  []string{
                  	... // 96 identical elements
                  	"                ]",
                  	"              }",
                - 	"            },",
...
        --- FAIL: TestCommand/common//tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif (7.22s)
            cmdtest.go:336: /tmp/buildlet/gopath/src/golang.org/x/vuln/cmd/govulncheck/testdata/common/testfiles/source-package/source_package_sarif.ct:3: want=-, got=+
                $ govulncheck -format sarif -scan package -C ${moddir}/vuln .
                  []string{
                  	... // 127 identical elements
                  	`          "message": {`,
                  	`            "text": "Your code imports 1 vulnerable package (git`...,
                - 	"          }",
                - 	"        },",
                - 	"        {",
...
                - 	"        },",
                - 	"        {",
                - 	`          "ruleId": "GO-2022-0969",`,
                - 	`          "level": "error",`,
                - 	`          "message": {`,
                - 	`            "text": "Your code depends on 1 vulnerable module (stdlib). Run the call-level analysis to understand whether your code actually calls the vulnerabilities."`,
                  	"          }",
                  	"        }",
                  	... // 4 identical elements
                  }

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-03-25 18:40 x_vuln-go1.21-windows-amd64-longtest vuln@6f169c6e release-branch.go1.21@efb7cc42 x/vuln/cmd/govulncheck.TestCommand (log) 
=== RUN   TestCommand
go: downloading github.com/tidwall/gjson v1.9.2
go: downloading github.com/tidwall/match v1.1.0
go: downloading github.com/tidwall/pretty v1.2.0
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
    buildtest.go:82: C:\b\s\w\ir\x\w\goroot\bin\go.exe build -o C:\b\s\w\ir\x\t\buildtest292136118\informational.exe: exit status 1
--- FAIL: TestCommand (1.05s)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "vuln" && test ~ `^TestCommand`
2024-04-18 21:51 x_vuln-go1.21-windows-amd64-longtest vuln@f3bc44a7 release-branch.go1.21@891ac91e x/vuln/cmd/govulncheck.TestCommand/common (log) 
=== RUN   TestCommand/common
go: downloading github.com/tidwall/gjson v1.9.2
go: downloading github.com/tidwall/match v1.1.0
go: downloading github.com/tidwall/pretty v1.2.0
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
    buildtest.go:82: C:\b\s\w\ir\x\w\goroot\bin\go.exe build -o C:\b\s\w\ir\x\t\buildtest2125034466\informational.exe: exit status 1
--- FAIL: TestCommand/common (1.01s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpavlinovic zpavlinovic

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Test Flakes
Status: Done
Milestone
vuln/v0.2.0
Development

No branches or pull requests
6 participants
@ianthehat @zpavlinovic @bcmills @julieqiu @gopherbot @bkessler-go