Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/misc: TestRenamePackage_Tests failures #59762

Closed
gopherbot opened this issue Apr 21, 2023 · 4 comments
Closed

x/tools/gopls/internal/regtest/misc: TestRenamePackage_Tests failures #59762

gopherbot opened this issue Apr 21, 2023 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Apr 21, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_Tests" && log ~ `panic: test timed out` && goos != "netbsd"

Issue created automatically to collect these failures.

Example (log):

serve.go:434: debug server listening at http://localhost:49253
serve.go:434: debug server listening at http://localhost:49254
panic: test timed out after 10m0s
running tests:
	TestRenamePackage_Tests (7m4s)
	TestRenamePackage_Tests/default (7m4s)

testing.(*T).Run(0xc001369040, {0x100b889b9?, 0x100ba5be2?}, 0xc004402370)
	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc0000d15e0, 0xc001369040, {0x100c02375, 0x1ae}, 0x100d0e2c8, {0x0, 0x0, 0xc000c34f60?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x491
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests(0xc000c34f60?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:480 +0x55
testing.tRunner(0xc001369040, 0x100d0e2d0)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 21, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_Tests"
2023-04-20 14:47 darwin-amd64-12_0 tools@ed3ff1b6 go@22a840aa x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log) 
serve.go:434: debug server listening at http://localhost:49253
serve.go:434: debug server listening at http://localhost:49254
panic: test timed out after 10m0s
running tests:
	TestRenamePackage_Tests (7m4s)
	TestRenamePackage_Tests/default (7m4s)

testing.(*T).Run(0xc001369040, {0x100b889b9?, 0x100ba5be2?}, 0xc004402370)
	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc0000d15e0, 0xc001369040, {0x100c02375, 0x1ae}, 0x100d0e2c8, {0x0, 0x0, 0xc000c34f60?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x491
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests(0xc000c34f60?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:480 +0x55
testing.tRunner(0xc001369040, 0x100d0e2d0)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 21, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 21, 2023
@findleyr
Copy link
Contributor

This is a dupe of #54461, and predates @bcmills' change to set WaitDelay.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
@gopherbot gopherbot reopened this May 17, 2023
@gopherbot

This comment was marked as off-topic.

Sign in to view
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
@gopherbot gopherbot reopened this Jun 30, 2023
@gopherbot

This comment was marked as off-topic.

Sign in to view
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr