Skip to content

x/vuln: exit with status 2 when relevant #59744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Apr 20, 2023 · 2 comments
Closed

x/vuln: exit with status 2 when relevant #59744

julieqiu opened this issue Apr 20, 2023 · 2 comments
Assignees
@julieqiu
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/v0.2.0

Comments

@julieqiu
Copy link
Member

Govulncheck should follow the go command pattern for exit status.

For example, in case when https://pkg.go.dev/flag#ExitOnError should be returned.
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 20, 2023
@julieqiu julieqiu added this to the vuln/v0.2.0 milestone Apr 20, 2023
@prattmic prattmic added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 21, 2023
@andrei-polukhin
Copy link

Addressed in https://go-review.googlesource.com/c/vuln/+/487736

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/487736 mentions this issue: x/vuln: exit with status 2 when relevant

@golang golang locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@julieqiu julieqiu

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/v0.2.0
Development

No branches or pull requests
4 participants
@prattmic @julieqiu @gopherbot @andrei-polukhin