Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/regtest/misc: TestRenamePackage_DuplicateImport failures #59703

Closed
gopherbot opened this issue Apr 19, 2023 · 4 comments
Closed
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Apr 19, 2023

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_DuplicateImport" && log ~ `panic: test timed out`

Issue created automatically to collect these failures.

Example (log):

serve.go:434: debug server listening at http://localhost:49658
serve.go:434: debug server listening at http://localhost:49659
panic: test timed out after 10m0s

testing.(*T).Run(0xc003057a00, {0x100bda500?, 0x100bf7630?}, 0xc004a279a0)
	/tmp/buildlet/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc00051bf40, 0xc003057a00, {0x100c4b162, 0x10a}, 0x100d5d518, {0x0, 0x0, 0xc003661f60?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x4e5
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateImport(0xc0022e24e0?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:608 +0x5b
testing.tRunner(0xc003057a00, 0x100d5d520)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 19, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_DuplicateImport"
2023-04-18 17:47 darwin-amd64-11_0 tools@85d651af go@130a7f8e x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateImport (log)
serve.go:434: debug server listening at http://localhost:49658
serve.go:434: debug server listening at http://localhost:49659
panic: test timed out after 10m0s

testing.(*T).Run(0xc003057a00, {0x100bda500?, 0x100bf7630?}, 0xc004a279a0)
	/tmp/buildlet/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc00051bf40, 0xc003057a00, {0x100c4b162, 0x10a}, 0x100d5d518, {0x0, 0x0, 0xc003661f60?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x4e5
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateImport(0xc0022e24e0?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:608 +0x5b
testing.tRunner(0xc003057a00, 0x100d5d520)

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 19, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 19, 2023
@findleyr
Copy link
Contributor

As predicted in #59541, this is just another instance of a hanging go command on darwin.

Nothing actionable here about this test. Discussion on that issue centers on how to consolidate these failures.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_DuplicateImport"
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@949d0f4f x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateImport (log)
--- FAIL: TestRenamePackage_DuplicateImport (0.64s)
    --- FAIL: TestRenamePackage_DuplicateImport/default (0.64s)
        rename_test.go:610: renaming sandbox file: rename /tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-1420221884/TestRenamePackage_DuplicateImport/default/work/lib /tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-1420221884/TestRenamePackage_DuplicateImport/default/work/nested: permission denied
2023-05-16 01:58 linux-amd64-wsl tools@7f203f0c go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateImport (log)
--- FAIL: TestRenamePackage_DuplicateImport (0.79s)
    --- FAIL: TestRenamePackage_DuplicateImport/default (0.79s)
        rename_test.go:610: renaming sandbox file: rename /tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-757905373/TestRenamePackage_DuplicateImport/default/work/lib /tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-757905373/TestRenamePackage_DuplicateImport/default/work/nested: permission denied
#### Start Gopls Test Logs for "TestRenamePackage_DuplicateBlankImport/default"
[Trace - 19:40:28.659 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-757905373/TestRenamePackage_DuplicateBlankImport/default/gopath","GOPROXY":"file:///tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-757905373/TestRenamePackage_DuplicateBlankImport/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-757905373/TestRenamePackage_DuplicateBlankImport/default/work","name":"work"}]}


[Trace - 19:40:28.660 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}
...

[Trace - 19:40:29.324 PM] Sending response 'window/workDoneProgress/create - (10)' in 0ms.
Result: 


[Trace - 19:40:29.326 PM] Received notification '$/progress'.
Params: {"token":"792596003370155090","value":{"kind":"begin","title":"diagnosing opened files","message":"Calculating file diagnostics..."}}


#### End Gopls Test Logs for "TestRenamePackage_DuplicateBlankImport/default"

watchflakes

@gopherbot gopherbot reopened this May 17, 2023
@bcmills
Copy link
Contributor

bcmills commented May 17, 2023

Filed the -wsl failures as #60266.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants