Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: add tests for binary mode #59693

Closed
julieqiu opened this issue Apr 18, 2023 · 1 comment
Closed

x/vuln: add tests for binary mode #59693

julieqiu opened this issue Apr 18, 2023 · 1 comment
Assignees
@julieqiu
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/v0.2.0

Comments

@julieqiu
Copy link
Member

julieqiu commented Apr 18, 2023 •
edited

We should add tests for binary mode for each of the test cases in cmd/govulncheck/testdata/
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 18, 2023
@julieqiu julieqiu added this to the vuln/v0.2.0 milestone Apr 18, 2023
@gopherbot
Copy link

Change https://go.dev/cl/486035 mentions this issue: cmd/govulncheck/testdata: add tests for -json binary mode

gopherbot pushed a commit to golang/vuln that referenced this issue Apr 18, 2023
@julieqiu
cmd/govulncheck/testdata: add tests for -json binary mode
22f32fd 
For golang/go#59693

Change-Id: I8ed6584305265cb9c1b2f7b2853ab08628441c8a
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/486035
Run-TryBot: Julie Qiu <julieqiu@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Julie Qiu <julieqiu@google.com>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
@julieqiu julieqiu self-assigned this Apr 18, 2023
@golang golang locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@julieqiu julieqiu

Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/v0.2.0
Development

No branches or pull requests
2 participants
@julieqiu @gopherbot