x/tools/gopls: restrict references to workspace packages #59674
Assignees
Labels
FrozenDueToAge
gopls/incremental
gopls
Issues related to the Go language server, gopls.
release-blocker
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
gopherbot
added
Tools
|
I don't think a rename operation should ever proceed with less than the complete scope of the identifier, as this would leave things in a bad state. If you really want to rename fmt.Println, it should touch every module in the module graph (and hopefully a good client will notice that you're attempting to modify readonly modules in the cache and abort before corrupting the cache or editing any other files). So I propose to leave out rename for now (as we discussed offline). |
|
Change https://go.dev/cl/487016 mentions this issue: |
|
Change https://go.dev/cl/487017 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Apr 21, 2023
This CL makes a number of preparatory cleanups before I tackle golang/go#59674: - (*snapshot).dumpWorkspace deleted (obsolete) - cache.newMemoizedFS deleted (dead code) - snapshot.workspaceMetadata deleted (use Snapshot.WorkspaceMetadata instead). - Snapshot.ActiveMetadata renamed WorkspaceMetadata and obsolete comment updated - (*snapshot).isWorkspacePackage deleted (dead code) [Interestingly this method didn't show up in the output of Rob's script.] - Snapshot: begin to group methods in a meaningful way. - Remove Get prefix from Snapshot.CriticalError - terminological tweaks. Updates golang/go#59674 Change-Id: I9c0fcd6073270f75dad0f2e91ac6b3864358a5f1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/487016 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Alan Donovan <adonovan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
After the rewrite of references/rename, these operations became agnostic to the set of workspace packages. As such, finding references on e.g.
fmt.Printlnwill find references throughout the module graph, not just in workspace modules.This is a change in behavior, may produce noisy references, and can lead to slow initial performance of queries, as we only pre-compute reference indexes for workspace packages.
We should filter these queries to workspace packages.
The text was updated successfully, but these errors were encountered: