Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/benchmarks/cmd/bent: some canned benchmarking scripts lack local-machine hooks #59671

Open
dr2chase opened this issue Apr 17, 2023 · 0 comments
Open

x/benchmarks/cmd/bent: some canned benchmarking scripts lack local-machine hooks #59671

dr2chase opened this issue Apr 17, 2023 · 0 comments
Assignees
@dr2chase
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dr2chase
Copy link
Contributor

The "nightly" script references a possibly-present script "localfix" that can modify the environment to make benchmarking better. For example, localfix-odroid-n2 contains

NUMACTL='numactl -C 2-5 --'
export GOMAXPROCS=4
B=3
N=15
BUILDER_TYPE="Odroid-N2-arm64"

which default-reduces the benchmarking numbers to a size more appropriate for a small arm64, but more importantly, defines NUMACTL so that benchmarking is entirely on the big processors of a BIG.little arm64.

Unfortunately, not all the scripts check localfix or reference NUMACTL.
@dr2chase dr2chase self-assigned this Apr 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 17, 2023
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr2chase dr2chase

Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dr2chase @gopherbot @seankhliao