Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/watchflakes: misattributed Fail in goroutine after … has completed #59668

Open
bcmills opened this issue Apr 17, 2023 · 0 comments
Open

x/build/cmd/watchflakes: misattributed Fail in goroutine after … has completed #59668

bcmills opened this issue Apr 17, 2023 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 17, 2023

In #59646, watchflakes reported an issue for a log that includes the line:

panic: Fail in goroutine after TestDialTimeout has completed

However, the pattern it filed erroneously attributed the failure to the TestDeadlineOnWrite test, which is unrelated except to the extent that it happened to be running when the stray Error call from the previous test was detected.

watchflakes should look for the Fail in goroutine after .* has completed log line and update its classification accordingly.

(attn @cherrymui)
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 17, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 17, 2023
@bcmills bcmills changed the title x/build/watchflakes: misattributed Fail in goroutine after … has completed x/build/cmd/watchflakes: misattributed Fail in goroutine after … has completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot