proposal: x/build: add a CI runner with CC="zig cc" for linux/amd64 #59666
Labels
Milestone
Comments
seankhliao
changed the title
|
cc @golang/release |
|
For the record, Go unit tests pass on How to run the unit tests (click here)zig-cc #!/bin/sh
export ZIG_GLOBAL_CACHE_DIR=/tmp/zig-global-cache
exec /usr/local/bin/zig cc -fno-sanitize=undefined "$@"And this patch: diff --git a/src/cmd/cgo/internal/testshared/shared_test.go b/src/cmd/cgo/internal/testshared/shared_test.go
index 34cf3f3141..5e5dbaea13 100644
--- a/src/cmd/cgo/internal/testshared/shared_test.go
+++ b/src/cmd/cgo/internal/testshared/shared_test.go
@@ -12,6 +12,7 @@ import (
"flag"
"fmt"
"go/build"
+ "internal/testenv"
"io"
"log"
"os"
@@ -682,6 +683,11 @@ func TestNotes(t *testing.T) {
// runtime, another package (dep2) that links against the first, and an
// executable that links against dep2.
func TestTwoGopathShlibs(t *testing.T) {
+ // -buildmode=shared is to be removed (#47788). Does not work with linux zig-cc.
+ b := testenv.Builder()
+ if strings.HasPrefix(b, "linux-") && strings.HasSuffix(b, "-zig-cc") {
+ t.Skipf("skipping on linux zig-cc")
+ }
goCmd(t, "install", "-buildmode=shared", "-linkshared", "./depBase")
goCmd(t, "install", "-buildmode=shared", "-linkshared", "./dep2")
goCmd(t, "install", "-linkshared", "./exe2")
@@ -689,6 +695,11 @@ func TestTwoGopathShlibs(t *testing.T) {
}
func TestThreeGopathShlibs(t *testing.T) {
+ // -buildmode=shared is to be removed (#47788). Does not work with linux zig-cc.
+ b := testenv.Builder()
+ if strings.HasPrefix(b, "linux-") && strings.HasSuffix(b, "-zig-cc") {
+ t.Skipf("skipping on linux zig-cc")
+ }
goCmd(t, "install", "-buildmode=shared", "-linkshared", "./depBase")
goCmd(t, "install", "-buildmode=shared", "-linkshared", "./dep2")
goCmd(t, "install", "-buildmode=shared", "-linkshared", "./dep3")
@@ -1085,6 +1096,11 @@ func TestPackageOrder(t *testing.T) {
// Test that GC data are generated correctly by the linker when it needs a type defined in
// a shared library. See issue 39927.
func TestGCData(t *testing.T) {
+ // -buildmode=shared is to be removed (#47788). Does not work with linux zig-cc.
+ b := testenv.Builder()
+ if strings.HasPrefix(b, "linux-") && strings.HasSuffix(b, "-zig-cc") {
+ t.Skipf("skipping on linux zig-cc")
+ }
goCmd(t, "install", "-buildmode=shared", "-linkshared", "./gcdata/p")
goCmd(t, "build", "-linkshared", "./gcdata/main")
runWithEnv(t, "running gcdata/main", []string{"GODEBUG=clobberfree=1"}, "./main")
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 04dfd22f88..1aebf7bded 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -1113,6 +1113,14 @@ func (t *tester) internalLink() bool {
// linkmode=internal isn't supported.
return false
}
+
+ // internal linkmode does not always work with zig-cc due to Golang's implicit
+ // dependency on gcc_s. See issue 59735.
+ b := os.Getenv("GO_BUILDER_NAME")
+ if strings.HasPrefix(b, "linux-") && strings.HasSuffix(b, "-zig-cc") {
+ return false
+ }
+
return true
}
Run like this: src$ GO_BUILDER_NAME=linux-amd64-zig-cc CC=zig-cc ./run.bashAlso in https://github.com/motiejus/go/blob/zig-cc-tests/README-zig-cc.md On |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Short Summary
Add a CI worker that runs Go's unit tests with
CC="zig cc"onlinux/amd64.About
zig ccOn Linux,
zig ccis a wrapper on top of LLVM and LLD. Main benefits compared to other popular compilers:libc.so.6on the fly before linking, no need to ship one).For example:
Will (cross-)compile the current package for
linux/arm64and link to glibc 2.17. Read this to learn more aboutzig cc.Zig also has it's own Mach-O linker, making it possible to cross-compile to OS X. This is not in scope for this proposal, but may be considered as a next step. cc @kubkon who expressed interest in this.
Logistics
Initial changes:
linux/amd64worker that lack any C/C++ compiler (i.e. make sure gcc/ld are not installed).zig v0.11(to be released in May) to the worker.CC="zig cc".Upkeep:
ReleaseSafe+Debugbuild, so, in case Zig crashes or trips an assertion, there will be decent information about the crash right in the logs. Refs Proposal: change nightlies from ReleaseFast to ReleaseSafe+debug ziglang/zig#15194.Why is this important?
As of writing a few companies are known to use
zig ccto compile C/C++ (via this toolchain) and bundle it with Go code. My employer Uber useszig ccto compile+link it's Go Monorepo forlinux/amd64andlinux/arm64. During the last 4 months that we have been usingzig ccin production (which included an upgrade to Go 1.20) we have encountered some issues in a released Go version that would have been caught in dev versions shouldzig ccworker be present:darwin/arm64would have triggered an assertion during linking with Zig.Since Go unit tests is a decent "integration" test, we believe it is a worth-while exercise to have this in CI.
The text was updated successfully, but these errors were encountered: