Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: runtime: Expose goid and gopc in GoroutineProfile #59663

Open
vaind opened this issue Apr 17, 2023 · 2 comments
Open

proposal: runtime: Expose goid and gopc in GoroutineProfile #59663

vaind opened this issue Apr 17, 2023 · 2 comments
Labels
Proposal
Milestone
Proposal

Comments

@vaind
Copy link

vaind commented Apr 17, 2023

While investigating runtime.GoroutineProfile() for profiling (sampling), I've noticed the resulting StackRecord is missing any way to identify a Goroutine across collected samples. Actual copy of goid and gopc from g could happen in saveg() to StackRecord, but I'm not sure that's the best idea, considering, StackRecord is also used in a couple of other places where it wouldn't make sense to add these fields. Also, it wouldn't be a generic StackRecord then...
@vaind vaind added the Proposal label Apr 17, 2023
@gopherbot gopherbot added this to the Proposal milestone Apr 17, 2023
@vaind vaind mentioned this issue Apr 17, 2023
Merged
7 tasks
@seankhliao
Copy link
Member

cc @golang/runtime

@vaind
Copy link
Author

vaind commented Nov 20, 2023 •
edited

Hey, is there something I can do to help get this happen? I'm looking for an alternative to calling runtime.stack(..., true) to get stack traces for all goroutines periodically because that is quite CPU heavy.

@vaind vaind mentioned this issue Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

No branches or pull requests
3 participants
@vaind @gopherbot @seankhliao