Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: Fail in goroutine after TestDialTimeout has completed #59646

Closed
gopherbot opened this issue Apr 15, 2023 · 2 comments
Closed

crypto/tls: Fail in goroutine after TestDialTimeout has completed #59646

gopherbot opened this issue Apr 15, 2023 · 2 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link

gopherbot commented Apr 15, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "crypto/tls" && `Fail in goroutine after TestDialTimeout has completed`

Issue created automatically to collect these failures.

Example (log):

panic: Fail in goroutine after TestDialTimeout has completed

syscall.fcntl(0xb?, 0x2?, 0x1?)
	/tmp/buildlet/go/src/syscall/zsyscall_darwin_amd64.go:318 +0xba fp=0xc0000644d8 sp=0xc0000644d0 pc=0x1076f3a
syscall.CloseOnExec(...)
	/tmp/buildlet/go/src/syscall/exec_unix.go:104
net.sysSocket(0xffffffffffffffff?, 0xc000450068?, 0x8c631?)
	/tmp/buildlet/go/src/net/sys_cloexec.go:25 +0x87 fp=0xc000064530 sp=0xc0000644d8 pc=0x11c70c7
net.socket({0x1397218, 0x1589dc0}, {0x13090ed, 0x3}, 0x2, 0x1, 0xc0000646e8?, 0xa8?, {0x1397ab8, 0x0}, ...)
	/tmp/buildlet/go/src/net/sock_posix.go:19 +0x65 fp=0xc0000645e0 sp=0xc000064530 pc=0x11c5345
...
	/tmp/buildlet/go/src/net/dial.go:496 +0x6de fp=0xc000064cc8 sp=0xc000064b90 pc=0x11af09e
crypto/tls.dial({0x1397218?, 0x1589dc0?}, 0xc000064dd0, {0x13090ed, 0x3}, {0xc00031e060, 0xf}, 0xc0002de000)
	/tmp/buildlet/go/src/crypto/tls/tls.go:133 +0x1a5 fp=0xc000064d90 sp=0xc000064cc8 pc=0x1234e25
crypto/tls.DialWithDialer(...)
	/tmp/buildlet/go/src/crypto/tls/tls.go:117
crypto/tls.Dial({0x13090ed?, 0x1?}, {0xc00031e060?, 0xc000212000?}, 0xc00031e028?)
	/tmp/buildlet/go/src/crypto/tls/tls.go:171 +0x7a fp=0xc000064e50 sp=0xc000064d90 pc=0x123525a
crypto/tls.TestDeadlineOnWrite(0xc00048e820)
	/tmp/buildlet/go/src/crypto/tls/tls_test.go:231 +0x1d6 fp=0xc000064f70 sp=0xc000064e50 pc=0x126b136
testing.tRunner(0xc00048e820, 0x1345f00)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 15, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "crypto/tls" && test == "TestDeadlineOnWrite"
2023-04-14 20:10 darwin-amd64-longtest go@5da1f415 crypto/tls.TestDeadlineOnWrite (log) 
panic: Fail in goroutine after TestDialTimeout has completed

syscall.fcntl(0xb?, 0x2?, 0x1?)
	/tmp/buildlet/go/src/syscall/zsyscall_darwin_amd64.go:318 +0xba fp=0xc0000644d8 sp=0xc0000644d0 pc=0x1076f3a
syscall.CloseOnExec(...)
	/tmp/buildlet/go/src/syscall/exec_unix.go:104
net.sysSocket(0xffffffffffffffff?, 0xc000450068?, 0x8c631?)
	/tmp/buildlet/go/src/net/sys_cloexec.go:25 +0x87 fp=0xc000064530 sp=0xc0000644d8 pc=0x11c70c7
net.socket({0x1397218, 0x1589dc0}, {0x13090ed, 0x3}, 0x2, 0x1, 0xc0000646e8?, 0xa8?, {0x1397ab8, 0x0}, ...)
	/tmp/buildlet/go/src/net/sock_posix.go:19 +0x65 fp=0xc0000645e0 sp=0xc000064530 pc=0x11c5345
...
	/tmp/buildlet/go/src/net/dial.go:496 +0x6de fp=0xc000064cc8 sp=0xc000064b90 pc=0x11af09e
crypto/tls.dial({0x1397218?, 0x1589dc0?}, 0xc000064dd0, {0x13090ed, 0x3}, {0xc00031e060, 0xf}, 0xc0002de000)
	/tmp/buildlet/go/src/crypto/tls/tls.go:133 +0x1a5 fp=0xc000064d90 sp=0xc000064cc8 pc=0x1234e25
crypto/tls.DialWithDialer(...)
	/tmp/buildlet/go/src/crypto/tls/tls.go:117
crypto/tls.Dial({0x13090ed?, 0x1?}, {0xc00031e060?, 0xc000212000?}, 0xc00031e028?)
	/tmp/buildlet/go/src/crypto/tls/tls.go:171 +0x7a fp=0xc000064e50 sp=0xc000064d90 pc=0x123525a
crypto/tls.TestDeadlineOnWrite(0xc00048e820)
	/tmp/buildlet/go/src/crypto/tls/tls_test.go:231 +0x1d6 fp=0xc000064f70 sp=0xc000064e50 pc=0x126b136
testing.tRunner(0xc00048e820, 0x1345f00)

— watchflakes

@bcmills bcmills self-assigned this Apr 17, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Apr 17, 2023
@bcmills bcmills added this to the Go1.21 milestone Apr 17, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 17, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/485115 mentions this issue: crypto/tls: retry DialWithTimeout until the listener accepts a connection

@bcmills bcmills mentioned this issue Apr 17, 2023
Open
@bcmills bcmills changed the title crypto/tls: TestDeadlineOnWrite failures crypto/tls: Fail in goroutine after TestDialTimeout has completed Apr 17, 2023
@golang golang locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot