Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/internal/gcimporter: lookupGorootExport should use the go command from build.Default.GOROOT [1.20 backport] #59637

Closed
gopherbot opened this issue Apr 14, 2023 · 3 comments
Closed

go/internal/gcimporter: lookupGorootExport should use the go command from build.Default.GOROOT [1.20 backport] #59637

gopherbot opened this issue Apr 14, 2023 · 3 comments
Assignees
@bcmills
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.4

Comments

@gopherbot
Copy link

@bcmills requested issue #59598 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.20. This could cause the importer to silently import from the wrong GOROOT in some cases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 14, 2023
@gopherbot gopherbot mentioned this issue Apr 14, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.4 milestone Apr 14, 2023
@bcmills
Copy link
Contributor

bcmills commented Apr 14, 2023

This does not need to be backported to Go 1.19, because the lookupGorootExport function is new in 1.20.
(Before 1.20, the export data for the standard library was installed in GOROOT/pkg, so it didn't need to call out to a go command.)

@bcmills bcmills self-assigned this Apr 14, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/484758 mentions this issue: cmd/compile/internal/importer,go/internal/gcimporter: use the 'go' command from build.Default.GOROOT in lookupGorootExport

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Apr 19, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 19, 2023
@gopherbot
Copy link
Author

Closed by merging 484535e to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Apr 24, 2023
@gopherbot
cmd/compile/internal/importer,go/internal/gcimporter: use the 'go' co…
484535e 
…mmand from build.Default.GOROOT in lookupGorootExport

Also set GOROOT explicitly in case it is set to something else in the
caller's environment.

Updates #59598.
Fixes #59637.

Change-Id: I5599ed1183b23187fc3b976786f3c320d42ef4f3
Reviewed-on: https://go-review.googlesource.com/c/go/+/484756
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
(cherry picked from commit 750e911)
Reviewed-on: https://go-review.googlesource.com/c/go/+/484758
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@bradfitz
cmd/compile/internal/importer,go/internal/gcimporter: use the 'go' co…
500021b 
…mmand from build.Default.GOROOT in lookupGorootExport

Also set GOROOT explicitly in case it is set to something else in the
caller's environment.

Updates golang#59598.
Fixes golang#59637.

Change-Id: I5599ed1183b23187fc3b976786f3c320d42ef4f3
Reviewed-on: https://go-review.googlesource.com/c/go/+/484756
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
(cherry picked from commit 750e911)
Reviewed-on: https://go-review.googlesource.com/c/go/+/484758
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@bradfitz
cmd/compile/internal/importer,go/internal/gcimporter: use the 'go' co…
6718616 
…mmand from build.Default.GOROOT in lookupGorootExport

Also set GOROOT explicitly in case it is set to something else in the
caller's environment.

Updates golang#59598.
Fixes golang#59637.

Change-Id: I5599ed1183b23187fc3b976786f3c320d42ef4f3
Reviewed-on: https://go-review.googlesource.com/c/go/+/484756
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
(cherry picked from commit 750e911)
Reviewed-on: https://go-review.googlesource.com/c/go/+/484758
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.4
Development

No branches or pull requests
3 participants
@prattmic @bcmills @gopherbot