Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: improve error message when running on invalid pattern #59623

Closed
julieqiu opened this issue Apr 13, 2023 · 1 comment
Closed

x/vuln: improve error message when running on invalid pattern #59623

julieqiu opened this issue Apr 13, 2023 · 1 comment
Assignees
@zpavlinovic
Labels
NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@julieqiu
Copy link
Member

julieqiu commented Apr 13, 2023 •
edited

Related: #59607

In github.com/u-root/u-root

govulncheck pkg/strace/... returns:

~/code/u-root main ❯ govulncheck pkg/strace/...                        04:54:49 PM
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using go1.20.3 and govulncheck@v0.0.0 with
vulnerability data from https://vuln.go.dev (last modified 2023-04-12 21:45:55 +0000 UTC).

Scanning your code and 0 packages across 0 dependent modules for known vulnerabilities...
No vulnerabilities found.

We should report that the pattern is invalid, instead of there being 0 packages.
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 13, 2023
@julieqiu julieqiu added this to the vuln/v0.1.0 milestone Apr 13, 2023
@julieqiu julieqiu changed the title x/vuln: improve error message when running on pattern without go.mod x/vuln: improve error message when running on invalid pattern Apr 14, 2023
@julieqiu julieqiu self-assigned this Apr 14, 2023
@julieqiu julieqiu modified the milestones: vuln/v0.1.0, vuln/unplanned Apr 17, 2023
@julieqiu julieqiu removed their assignment Jul 30, 2023
@dr2chase dr2chase added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 4, 2023
@zpavlinovic zpavlinovic self-assigned this Sep 27, 2023
@gopherbot
Copy link

Change https://go.dev/cl/532056 mentions this issue: internal/scan: return error when patterns matches no packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpavlinovic zpavlinovic

Labels
NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
4 participants
@zpavlinovic @dr2chase @julieqiu @gopherbot