Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: add Cmd.Env #59619

Closed
julieqiu opened this issue Apr 13, 2023 · 1 comment
Closed

x/vuln: add Cmd.Env #59619

julieqiu opened this issue Apr 13, 2023 · 1 comment
Assignees
@ianthehat
Labels
vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@julieqiu
Copy link
Member

Add a Cmd.Env field to https://github.com/golang/vuln/blob/master/internal/scan/scan.go#L16

Follow the same spec as https://pkg.go.dev/os/exec#Cmd.Env and https://pkg.go.dev/golang.org/x/tools/go/packages#Config.Env.
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 13, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Apr 13, 2023
@julieqiu julieqiu assigned ianthehat and unassigned tatianab May 2, 2023
@ianthehat ianthehat modified the milestones: vuln/v0.2.0, vuln/unplanned May 18, 2023
@gopherbot
Copy link

Change https://go.dev/cl/499456 mentions this issue: scan: Add Env to Cmd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianthehat ianthehat

Labels
vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
4 participants
@ianthehat @julieqiu @tatianab @gopherbot