Skip to content

x/vuln: remove package path from receiver #59618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Apr 13, 2023 · 2 comments
Closed

x/vuln: remove package path from receiver #59618

julieqiu opened this issue Apr 13, 2023 · 2 comments
Assignees
@tatianab
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/v0.1.0

Comments

@julieqiu
Copy link
Member

Example: https://github.com/julieqiu/govulncheckdemo/blob/7321d26f4defec4c9bce3d8b3f1fc4926763cc35/examples/module3_output.json#L103

Receiver should just be *DHT instead of *github.com/shiyanhui/dht.DHT
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 13, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Apr 13, 2023
@julieqiu julieqiu modified the milestones: vuln/unplanned, vuln/v0.1.0 Apr 13, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/485416 mentions this issue: internal/{scan,vulncheck}: remove package path from Receiver

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/485415 mentions this issue: cmd/govulncheck/testdata: exercise receiver value in JSON tests

gopherbot pushed a commit to golang/vuln that referenced this issue Apr 17, 2023
@tatianab
cmd/govulncheck/testdata: exercise receiver value in JSON tests
3f3344b 
Use a vulnerable method with a receiver in the test module so that
the "receiver" field is populated in tests.

This will allow us to test changed behavior in a follow-up CL.

For golang/go#59618

Change-Id: I724dd866cc6e0fced803e12e8deb2f4d12bfe8ce
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/485415
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Julie Qiu <julieqiu@google.com>
@golang golang locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tatianab tatianab

Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/v0.1.0
Development

No branches or pull requests
3 participants
@julieqiu @tatianab @gopherbot