Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: remove summary and symbol from callstacks #59617

Closed
julieqiu opened this issue Apr 13, 2023 · 2 comments
Closed

x/vuln: remove summary and symbol from callstacks #59617

julieqiu opened this issue Apr 13, 2023 · 2 comments
Assignees
@julieqiu
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/v0.2.0

Comments

@julieqiu
Copy link
Member

julieqiu commented Apr 13, 2023 •
edited

Example: https://github.com/julieqiu/govulncheckdemo/blob/7321d26f4defec4c9bce3d8b3f1fc4926763cc35/examples/module3_output.json#L115

We only need this information for the text output. Remove summary and symbol from the JSON output.

We do need enough information from the JSON output to regenerated the text output, for #59552.
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 13, 2023
@julieqiu julieqiu added this to the vuln/v0.1.0 milestone Apr 13, 2023
@julieqiu julieqiu self-assigned this Apr 13, 2023
@julieqiu julieqiu modified the milestones: vuln/v0.1.0, vuln/v0.2.0 Apr 17, 2023
@gopherbot
Copy link

Change https://go.dev/cl/485237 mentions this issue: internal: remove Summary

@julieqiu julieqiu changed the title x/vuln: remove summary from JSON output x/vuln: remove summary and symbol from callstacks Apr 19, 2023
@gopherbot
Copy link

Change https://go.dev/cl/486355 mentions this issue: internal/scan: remove symbol

gopherbot pushed a commit to golang/vuln that referenced this issue Apr 19, 2023
@julieqiu
internal: remove Summary
d44ddb5 
The summary field can be regenerated from the callstacks, so don't
include it in the JSON.

For golang/go#59617

Change-Id: Ia86be10a3647555238db6e7afcad7f9cd3caff23
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/485237
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
gopherbot pushed a commit to golang/vuln that referenced this issue Apr 19, 2023
@julieqiu
internal/scan: remove symbol
ceb2c82 
The symbol field can be regenerated from the callstacks, so don't
include it in the JSON.

For golang/go#59617

Change-Id: Ic5fc6d26d9a7e9901a22c27118267d380bd3ae2c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/486355
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Julie Qiu <julieqiu@google.com>
@golang golang locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@julieqiu julieqiu

Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/v0.2.0
Development

No branches or pull requests
2 participants
@julieqiu @gopherbot