Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/template: expose ErrJSTemplate #59584

Closed
rolandshoemaker opened this issue Apr 12, 2023 · 7 comments
Closed

html/template: expose ErrJSTemplate #59584

rolandshoemaker opened this issue Apr 12, 2023 · 7 comments
Labels
Proposal Proposal-Accepted Proposal-Security PUBLIC issues for security fixes, per https://go.dev/security/policy
Milestone
Go1.21

Comments

@rolandshoemaker
Copy link
Member

In CL482079 we added the unexported error code errJSTmplLit for when an action appears in a JS template literal. Since we added this in a minor security release, we could not export it. We should export it so that users can compare error codes directly.
@gopherbot gopherbot added this to the Proposal milestone Apr 12, 2023
@rsc
Copy link
Contributor

rsc commented Apr 19, 2023

Can we find a more readable name? It reads like a cryptic C name more than a Go template.
ErrJSBackquote or ErrJSTemplate would be OK I think.

@rsc
Copy link
Contributor

rsc commented Apr 19, 2023

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rolandshoemaker
Copy link
Member Author

I like ErrJSTemplate.

@julieqiu julieqiu added the Proposal-Security PUBLIC issues for security fixes, per https://go.dev/security/policy label May 3, 2023
@rsc rsc changed the title proposal: html/template: expose errJSTmplLit proposal: html/template: expose ErrJSTemplate May 3, 2023
@rsc
Copy link
Contributor

rsc commented May 3, 2023

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented May 10, 2023

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: html/template: expose ErrJSTemplate html/template: expose ErrJSTemplate May 10, 2023
@rsc rsc modified the milestones: Proposal, Backlog May 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/496395 mentions this issue: html/template: expose ErrJSTemplate

@dmitshur dmitshur modified the milestones: Backlog, Go1.21 May 19, 2023
@mknyszek mknyszek mentioned this issue Jun 1, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/501698 mentions this issue: doc/go1.21: mention html/template.ErrJSTemplate

gopherbot pushed a commit that referenced this issue Jun 8, 2023
@ianlancetaylor @gopherbot
doc/go1.21: mention html/template.ErrJSTemplate
471561c 
For #59584

Change-Id: Iaa3f8b23010ad452c134ac608c63d2a41cc4e409
Reviewed-on: https://go-review.googlesource.com/c/go/+/501698
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Bypass: Ian Lance Taylor <iant@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal Proposal-Accepted Proposal-Security PUBLIC issues for security fixes, per https://go.dev/security/policy
Projects
Proposals
Status: Accepted
Milestone
Go1.21
Development

No branches or pull requests
5 participants
@rsc @dmitshur @rolandshoemaker @julieqiu @gopherbot