Comment 1:

Labels changed: added priority-later, feature, removed priority-triage.

Status changed to Accepted.

Comment 2:

Labels changed: removed feature.

Comment 3:

Labels changed: added go1.3maybe.

Comment 4:

Labels changed: added release-none, removed go1.3maybe.

Comment 5:

Labels changed: added repo-net.

3 year later, and nothing had happened yet.

@klausenbusk, see https://golang.org/wiki/NoMeToo

Perhaps you can elaborate on why this is a problem for you in practice? Can you describe your environment? Do underlying TCP keep-alive mechanisms not adequately cull dead connections?

Haproxy removes connections that have not pinged for X minutes. So golang websocket connections are cut off every 2 minutes in my case.

TCP keep alive != websocket keepalive because in the case there is a proxy between the client and server, tcp keepalives will go between the proxy and each endpoint, whereas websocket ping pong works and to end.

You can 'manually' send a ping frame - what is worse tho is that whether the remote side sends a pong in response or not, makes no difference - it is discarded, with no api to allow the client code to respond to a dead client.

I suspect the intention of x/net/websocket would be to defer to the underlying net timeout mechanism, but provides no mechanism to extend the read deadline on a good frame read.

@danmux any hint on how pings could be sent manually? The marshalling function looks like this:

func marshal(v interface{}) (msg []byte, payloadType byte, err error) {
	switch data := v.(type) {
	case string:
		return []byte(data), TextFrame, nil
	case []byte:
		return data, BinaryFrame, nil
	}
	return nil, UnknownFrame, ErrNotSupported
}

It is either text or binary, with no way to set the type to PingFrame.

@danmux any hint on how pings could be sent manually? The marshalling function looks like this:

codec := websocket.Codec{Marshal: func(v interface{}) (data []byte, payloadType byte, err error) {
	return nil, websocket.PingFrame, nil
}}
if err := codec.Send(ws, nil); err != nil {
	ws.Close()
}

@klausenbusk thanks, appreciated!

why is it still open issue?

@mkungla, because it's not yet implemented. Or are you asking why people haven't prioritized fixing this?

Thanks everyone for the engagement on this issue, and for the patience.

We no longer maintain x/net/websocket and instead recommend these libraries:

• https://godoc.org/github.com/gorilla/websocket
• https://godoc.org/nhooyr.io/websocket

But at least a work around of manual pings was suggested by @danmux in #5958 (comment), and code was provided by @klausenbusk in #5958 (comment).

Thus, I shall close this issue. Thank you again.