Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log/syslog: TestWithSimulated failures #59568

Open
gopherbot opened this issue Apr 12, 2023 · 3 comments
Open

log/syslog: TestWithSimulated failures #59568

gopherbot opened this issue Apr 12, 2023 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWithSimulated"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestWithSimulated (0.00s)
    --- FAIL: TestWithSimulated/udp (0.41s)
        syslog_test.go:294: Got "<14>2023-04-11T18:54:00-04:00 Gophers-iMac-Pro.local syslog_test[6558]: Test 123\n", does not match template "<14>%s %s syslog_test[%d]: Test 123\n" (3 %!s(<nil>))

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 12, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWithSimulated"
2023-04-11 22:42 darwin-amd64-10_15 go@bc5b1948 log/syslog.TestWithSimulated (log) 
--- FAIL: TestWithSimulated (0.00s)
    --- FAIL: TestWithSimulated/udp (0.41s)
        syslog_test.go:294: Got "<14>2023-04-11T18:54:00-04:00 Gophers-iMac-Pro.local syslog_test[6558]: Test 123\n", does not match template "<14>%s %s syslog_test[%d]: Test 123\n" (3 %!s(<nil>))

— watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/483915 mentions this issue: log/syslog: report hostname mismatch error details

gopherbot pushed a commit that referenced this issue Apr 12, 2023
@prattmic @gopherbot
log/syslog: report hostname mismatch error details
ebc13fb 
The existing error log in check doesn't report the got/want hostname
even though that can be the cause of the error. Log those as well.

While we're here, also report os.Hostname() errors.

For #59568.

Change-Id: Ia277f85eddc541f2e78d719bc731db24e4513754
Reviewed-on: https://go-review.googlesource.com/c/go/+/483915
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWithSimulated"
2023-06-06 21:29 netbsd-arm-bsiegert go@5b6e6d2b log/syslog.TestWithSimulated (log) 
panic: test timed out after 30m0s
running tests:
	TestWithSimulated (30m0s)
	TestWithSimulated/unixgram (30m0s)

runtime.gopark(0x1c09f0, 0x2d9a80, 0x12, 0x19, 0x4)
	/var/gobuilder/buildlet/go/src/runtime/proc.go:398 +0x104 fp=0x533de4 sp=0x533dd0 pc=0x534dc
runtime.goparkunlock(...)
	/var/gobuilder/buildlet/go/src/runtime/proc.go:404
runtime.semacquire1(0x587eb8, 0x0, 0x1, 0x0, 0x12)
	/var/gobuilder/buildlet/go/src/runtime/sema.go:160 +0x26c fp=0x533e0c sp=0x533de4 pc=0x67b20
sync.runtime_Semacquire(0x587eb8)
	/var/gobuilder/buildlet/go/src/runtime/sema.go:62 +0x3c fp=0x533e24 sp=0x533e0c pc=0x86c98
sync.(*WaitGroup).Wait(0x587eb0)
	/var/gobuilder/buildlet/go/src/sync/waitgroup.go:116 +0x68 fp=0x533e40 sp=0x533e24 pc=0x90f50
log/syslog.TestWithSimulated.func1.1()
	/var/gobuilder/buildlet/go/src/log/syslog/syslog_test.go:154 +0x28 fp=0x533e48 sp=0x533e40 pc=0x1749e4
runtime.deferCallSave(0x533e88, 0x533f58)
	/var/gobuilder/buildlet/go/src/runtime/panic.go:798 +0x90 fp=0x533e50 sp=0x533e48 pc=0x4f858
runtime.runOpenDeferFrame(0x59c240)
	/var/gobuilder/buildlet/go/src/runtime/panic.go:771 +0x1bc fp=0x533e70 sp=0x533e50 pc=0x4f668
runtime.Goexit()
	/var/gobuilder/buildlet/go/src/runtime/panic.go:523 +0x18c fp=0x533ea4 sp=0x533e70 pc=0x4ed24
testing.(*common).FailNow(0x5be0f0)
	/var/gobuilder/buildlet/go/src/testing/testing.go:999 +0x50 fp=0x533ed4 sp=0x533ea4 pc=0xfc4d0
testing.(*common).Fatalf(0x5be0f0, {0x1b67f8, 0x11}, {0x533f60, 0x1, 0x1})
	/var/gobuilder/buildlet/go/src/testing/testing.go:1083 +0x80 fp=0x533f04 sp=0x533ed4 pc=0xfd094
log/syslog.TestWithSimulated.func1(0x5be0f0)
	/var/gobuilder/buildlet/go/src/log/syslog/syslog_test.go:161 +0x2a8 fp=0x533f94 sp=0x533f04 pc=0x174760
testing.tRunner(0x5be0f0, 0x59e0a8)

— watchflakes

eric pushed a commit to fancybits/go that referenced this issue Sep 7, 2023
@prattmic @eric
log/syslog: report hostname mismatch error details
2ad7e19 
The existing error log in check doesn't report the got/want hostname
even though that can be the cause of the error. Log those as well.

While we're here, also report os.Hostname() errors.

For golang#59568.

Change-Id: Ia277f85eddc541f2e78d719bc731db24e4513754
Reviewed-on: https://go-review.googlesource.com/c/go/+/483915
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
eric pushed a commit to fancybits/go that referenced this issue Sep 7, 2023
@prattmic @eric
log/syslog: report hostname mismatch error details
c25164e 
The existing error log in check doesn't report the got/want hostname
even though that can be the cause of the error. Log those as well.

While we're here, also report os.Hostname() errors.

For golang#59568.

Change-Id: Ia277f85eddc541f2e78d719bc731db24e4513754
Reviewed-on: https://go-review.googlesource.com/c/go/+/483915
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gopherbot