Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: do not send Connection header for responses to HTTP/1.0 requests #5955

Closed
josharian opened this issue Jul 25, 2013 · 4 comments
Closed
Milestone

Comments

@josharian
Copy link
Contributor

What steps will reproduce the problem?

Run a skeleton http server locally:

http://play.golang.org/p/1YW_Kl8iYn

then

curl -0 -v localhost:6000


What is the expected output?

No Connection header in the response.


What do you see instead?

Trimmed down a bit,

$ curl -0 -v localhost:6000
> GET / HTTP/1.0
> User-Agent: curl/7.24.0 (x86_64-apple-darwin12.0) libcurl/7.24.0 OpenSSL/0.9.8x
zlib/1.2.5
> Host: localhost:6000
> Accept: */*
> 
< HTTP/1.0 200 OK
< Content-Type: text/plain; charset=utf-8
< Content-Length: 0
< Connection: close
< Date: Thu, 25 Jul 2013 01:25:11 GMT
< 



Which compiler are you using (5g, 6g, 8g, gccgo)?

6g


Which operating system are you using?

OS X


Which version are you using?  (run 'go version')

1.1.1


Please provide any additional information below.

This came out of discussion at https://golang.org/issue/5950
@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 1:

Labels changed: added priority-later, go1.2, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 2:

Labels changed: added feature.

@josharian
Copy link
Contributor Author

Comment 3:

https://golang.org/cl/12435043

@bradfitz
Copy link
Contributor

bradfitz commented Aug 7, 2013

Comment 4:

This issue was closed by revision 1535727.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants