Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: can not show dependencies with vendor directory #59542

Open
aarzilli opened this issue Apr 11, 2023 · 1 comment
Open

x/pkgsite: can not show dependencies with vendor directory #59542

aarzilli opened this issue Apr 11, 2023 · 1 comment
Assignees
@findleyr
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/backlog

Comments

@aarzilli
Copy link
Contributor

pkgsite when run locally can not show packages outside of the main module if there is a vendor directory. For example

$ git clone github.com/go-delve/delve
$ cd delve
$ pkgsite

and open http://localhost:8080/github.com/hashicorp/golang-lru/simplelru
@gopherbot gopherbot added this to the Unreleased milestone Apr 11, 2023
@hyangah hyangah mentioned this issue Apr 12, 2023
Open
6 tasks
@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Apr 12, 2023
@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 12, 2023
@findleyr findleyr self-assigned this Apr 12, 2023
@findleyr
Copy link
Contributor

The problem is related to the fact that pkgsite fetch is based on modules, and vendored packages lack module info.

Therefore, this is part of a larger project to allow cmd/pkgsite to refresh packages at the package level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
4 participants
@aarzilli @hyangah @gopherbot @findleyr