Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/godoc: static files links old tour mod/url #59505

Open
crisman opened this issue Apr 8, 2023 · 2 comments · May be fixed by golang/tools#434
Open

x/tools/godoc: static files links old tour mod/url #59505

crisman opened this issue Apr 8, 2023 · 2 comments · May be fixed by golang/tools#434
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@crisman
Copy link
Contributor

crisman commented Apr 8, 2023

What did you do?

View the main page of a godoc server under Sub-repositories

http://127.0.0.1:6060/pkg/#subrepo

What did you expect to see?

Links to the current tour (under x/website) and and tour URL go.dev/tour

What did you see instead?

Old (x/tour) mod link and tour.golang.org.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 8, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 8, 2023
crisman added a commit to crisman/golang_tools that referenced this issue Apr 8, 2023
The tour links under Sub-repositories on the main page of the godoc server
are pointing at the old module (outside of x/website) and the old (pre
go.dev) public URL. Should be updated to match the new homes of the tour.

Update packageroot.html to point at the new tour package doc in
x/website/tour and generate the godoc static content.

Fixes golang/go#59505
@crisman crisman linked a pull request Apr 8, 2023 that will close this issue
@gopherbot
Copy link

Change https://go.dev/cl/483315 mentions this issue: godoc/static: Update subrepo tour links

@dr2chase
Copy link
Contributor

@golang/tools-team

@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants