Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add a special case to search ONLY within std / stdlib #59495

Open
henderjon opened this issue Apr 8, 2023 · 2 comments
Open

x/pkgsite: add a special case to search ONLY within std / stdlib #59495

henderjon opened this issue Apr 8, 2023 · 2 comments
Assignees
@jba
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/unplanned

Comments

@henderjon
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/std

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36

Screenshot

N/A

What did you do?

When I type something like NewReader it searches everything. I would like to see a way to confine my search to standard library. It's nice that stdlib results are labeled as such but either a special case or syntax addition to actual constrain my search would be very helpful.
@gopherbot gopherbot added this to the Unreleased milestone Apr 8, 2023
@hyangah hyangah added FeatureRequest Issues asking for a new feature that does not need a proposal. pkgsite/search Issues related to pkg.go.dev search functionality labels Apr 12, 2023
@hyangah hyangah modified the milestones: Unreleased, pkgsite/unplanned Apr 12, 2023
@hyangah
Copy link
Contributor

hyangah commented Apr 12, 2023

Looks like "Searching by symbol" supports an option to limit search with package path (so, module path too). However, standard library doesn't have a common package path name so we cannot utilize this option for stdlib. And, even when std or stdlib (pseudo module names used in vuln db or in the go project) is usable, they are too common. So, as @henderjon suggested we may need a special case or search syntax.

In the mean time, users may be able to search from the source repo (e.g. https://cs.opensource.google/search?q=NewReader&sq=&ss=go%2Fgo) or source code search services like sourcegraph, etc.

@mvdan mvdan mentioned this issue Oct 9, 2023
Open
@seankhliao
Copy link
Member

with CL 644676 "std/" is recognized as a prefix for the standard library, it should probably also be made to work with symbol search

cc @jba

@jba jba self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jba jba

Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
5 participants
@henderjon @hyangah @gopherbot @seankhliao @jba